# Re: \[PATCH v2 0/3\] serial: liteuart: fix driver unbind

- From: Andy Shevchenko \<hidden\>
- Date: 2021-11-17 10:43:41 
- List: linux-serial
- Page: https://ratatoskr.run/linux-serial/2021/11/1577388
- Thread: https://ratatoskr.run/linux-serial/2021/11/1577364/t.md

```text
On Wed, Nov 17, 2021 at 12:05 PM Johan Hovold [ref] wrote:
>
> Ilia Sergachev noted that the liteuart remove() function would trigger a
> NULL-pointer dereference if it was ever called since the driver data
> pointer was never initialised.
>
> Turns out there are more bugs in this part of the driver which clearly
> has never been tested.
>
> Also relax the Kconfig dependencies so that the driver can be
> compile-tested without first enabling a seemingly unrelated SoC
> controller driver.
>
> Note that this series depends on the fix by Ilia:
>
>         https://lore.kernel.org/r/20211115031808.7ab632ef@dtkw


FWIW,
Reviewed-by: Andy Shevchenko <redacted>

> Johan
>
>
> Changes in v2
>  - allow compile testing without CONFIG_OF (Andy)
>  - reword commit message to clarify that LITEX is neither a build or
>    runtime dependency and that the change only makes it easier to
>    compile test the driver
>  - move the Kconfig patch last in the series
>  - add Stafford's reviewed by tags to the two unmodified patches
>
>
> Johan Hovold (3):
>   serial: liteuart: fix use-after-free and memleak on unbind
>   serial: liteuart: fix minor-number leak on probe errors
>   serial: liteuart: relax compile-test dependencies
>
>  drivers/tty/serial/Kconfig    |  2 +-
>  drivers/tty/serial/liteuart.c | 18 +++++++++++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
>
> --
> 2.32.0
>


-- 
With Best Regards,
Andy Shevchenko
```