# Re: \[PATCH\] parisc: Make struct parisc\_driver::remove() return void

- From: Uwe Kleine-König \<hidden\>
- Date: 2021-08-07 09:12:06 
- List: linux-serial
- Page: https://ratatoskr.run/linux-serial/2021/08/6746989
- Thread: https://ratatoskr.run/alsa-devel/2021/08/6746982/t.md

```text
Hello,

On Fri, Aug 06, 2021 at 12:49:27PM -0500, Corey Minyard wrote:
> On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> > -int ipmi_si_remove_by_dev(struct device *dev)
> > +void ipmi_si_remove_by_dev(struct device *dev)
> 
> This function is also used by ipmi_si_platform.c, so you can't change
> this.

Did you see that I adapted ipmi_si_platform.c below? That is an instance
of "Make [ipmi_si_remove_by_dev] return void, too, as for all other
callers the value is ignored, too." (In ipmi_si_platform.c the return
value is used in a struct platform_driver::remove function. The value
returned there is ignored, see commit
e5e1c209788138f33ca6558bf9f572f6904f486d.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-serial/2021/08/6746989/attachment/0) (application/pgp-signature, 488 bytes)