Thread (7 messages) 7 messages, 3 authors, 2017-10-20

Re: [PATCH 1/2] serdev: ttyport: enforce tty-driver open() requirement

From: Rob Herring <robh@kernel.org>
Date: 2017-10-20 21:44:04
Also in: lkml

On Fri, Oct 20, 2017 at 7:21 AM, Greg Kroah-Hartman
[off-list ref] wrote:
On Tue, Oct 17, 2017 at 11:07:20AM -0500, Rob Herring wrote:
quoted
On Mon, Oct 16, 2017 at 8:06 AM, Johan Hovold [off-list ref] wrote:
quoted
The tty-driver open routine is mandatory, but the serdev
tty-port-controller implementation did not treat it as such and would
instead fall back to calling tty_port_open() directly.
The idea was to eventually get rid of the tty_struct dependency and
only depend on tty_port. That's very invasive though and needs various
pieces of tty_struct to move into tty_port.

Of course, tty_port_open itself would have to change as well, so this
change doesn't really matter.
So are you acking these patches?
Yeah, I guess. I was mainly trying to give some background on why it
was done the way it was.

For both:

Acked-by: Rob Herring <robh@kernel.org>

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help