Re: [PATCH 2/2] serdev: ttyport: add missing open() error handling
From: Rob Herring <robh@kernel.org>
Date: 2017-10-17 16:09:20
Also in:
lkml
From: Rob Herring <robh@kernel.org>
Date: 2017-10-17 16:09:20
Also in:
lkml
On Mon, Oct 16, 2017 at 8:06 AM, Johan Hovold [off-list ref] wrote:
Add missing error handling for tty-driver open() which may fail (e.g. if resource allocation fails or if a port is being disconnected). Note that close() must be called also in case of failed open() and that the operation sanity check is amended to catch buggy drivers.
That's a very odd pattern. Wouldn't a must_check annotation be enough? Rob