'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
--
2.7.4
ACPICA commit 1607b69238df9c1b2940262a17aa94ec49033278
Link: https://github.com/acpica/acpica/commit/1607b692
Signed-off-by: Aleksey Makarov <redacted>.
Signed-off-by: Bob Moore <redacted>
Signed-off-by: Lv Zheng <redacted>
---
DO NOT MERGE
This patch is from pending ACPICA series [1]. It is needed by the next patch,
but has not been merged to linux-next yet.
[1] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
include/acpi/actbl2.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
Signed-off-by: Leif Lindholm <redacted>
Signed-off-by: Aleksey Makarov <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
drivers/of/fdt.c | 11 +----------
drivers/tty/serial/earlycon.c | 2 +-
include/linux/of_fdt.h | 2 ++
3 files changed, 4 insertions(+), 11 deletions(-)
@@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_EC_DEBUGFS) += ec_sys.oobj-$(CONFIG_ACPI_CUSTOM_METHOD)+=custom_method.oobj-$(CONFIG_ACPI_BGRT)+=bgrt.oobj-$(CONFIG_ACPI_CPPC_LIB)+=cppc_acpi.o+obj-$(CONFIG_ACPI_SPCR_TABLE)+=spcr.oobj-$(CONFIG_ACPI_DEBUGGER_USER)+=acpi_dbg.o# processor has its own "processor." module_param namespace
This patch adds function pl011_console_match() that implements
method match of struct console. It allows to match consoles against
data specified in a string, for example taken from command line or
compiled by ACPI SPCR table handler.
Signed-off-by: Aleksey Makarov <redacted>
---
drivers/tty/serial/amba-pl011.c | 56 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
@@ -2287,12 +2287,68 @@ static int __init pl011_console_setup(struct console *co, char *options)returnuart_set_options(&uap->port,co,baud,parity,bits,flow);}+/**+*pl011_console_match-non-standardconsolematching+*@co:registeringconsole+*@name:namefromconsolecommandline+*@idx:indexfromconsolecommandline+*@options:ptrtooptionstringfromconsolecommandline+*+*Onlyattemptstomatchconsolecommandlinesoftheform:+*console=pl011,mmio|mmio32,<addr>[,<options>]+*console=pl011,0x<addr>[,<options>]+*Thisformisusedtoregisteraninitialearlyconbootconsoleand+*replaceitwiththeamba_consoleatpl011driverinit.+*+*Performsconsolesetupforamatch(asrequiredbyinterface)+*Ifno<options>arespecified,thenassumetheh/wisalreadysetup.+*+*Returns0ifconsolematches;otherwisenon-zerotousedefaultmatching+*/+staticint__initpl011_console_match(structconsole*co,char*name,intidx,+char*options)+{+charmatch[]="pl011";/* pl011-specific earlycon name */+unsignedchariotype;+unsignedlongaddr;+inti;++if(strncmp(name,match,5)!=0)+return-ENODEV;++if(uart_parse_earlycon(options,&iotype,&addr,&options))+return-ENODEV;++/* try to match the port specified on the command line */+for(i=0;i<ARRAY_SIZE(amba_ports);i++){+structuart_port*port;++if(!amba_ports[i])+continue;++port=&amba_ports[i]->port;++if(port->iotype!=iotype)+continue;+if((iotype==UPIO_MEM||iotype==UPIO_MEM32)&&+(port->mapbase!=addr))+continue;++co->index=i;+port->cons=co;+returnpl011_console_setup(co,options);+}++return-ENODEV;+}+staticstructuart_driveramba_reg;staticstructconsoleamba_console={.name="ttyAMA",.write=pl011_console_write,.device=uart_console_device,.setup=pl011_console_setup,+.match=pl011_console_match,.flags=CON_PRINTBUFFER,.index=-1,.data=&amba_reg,
SBBR mentions SPCR as a mandatory ACPI table. So enable it for ARM64
Earlycon should be set up as early as possible. ACPI boot tables are
mapped in arch/arm64/kernel/acpi.c:acpi_boot_table_init() that
is called from setup_arch() and that's where we parse SPCR.
So it has to be opted-in per-arch.
When ACPI_SPCR_TABLE is defined initialization of DT earlycon is
deferred until the DT/ACPI decision is done. Initialize DT earlycon
if ACPI is disabled.
Signed-off-by: Aleksey Makarov <redacted>
---
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 ++++++++++-
2 files changed, 11 insertions(+), 1 deletion(-)
On Thu, Mar 31, 2016 at 04:40:23PM +0300, Aleksey Makarov wrote:
quoted hunk
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
Signed-off-by: Leif Lindholm <redacted>
Signed-off-by: Aleksey Makarov <redacted>
Acked-by: Rob Herring <redacted>
---
drivers/of/fdt.c | 11 +----------
drivers/tty/serial/earlycon.c | 2 +-
include/linux/of_fdt.h | 2 ++
3 files changed, 4 insertions(+), 11 deletions(-)
Doesn't this change the default logic? Today you are returning 0 if you
don't have this config option set, and now you return -ENODEV, did you
test this out?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 31, 2016 at 04:40:23PM +0300, Aleksey Makarov wrote:
quoted
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
Signed-off-by: Leif Lindholm <redacted>
Signed-off-by: Aleksey Makarov <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
drivers/of/fdt.c | 11 +----------
drivers/tty/serial/earlycon.c | 2 +-
include/linux/of_fdt.h | 2 ++
3 files changed, 4 insertions(+), 11 deletions(-)
Doesn't this change the default logic? Today you are returning 0 if you
don't have this config option set,
I am not sure I understand this. Which return value do you mean?
1. early_init_dt_scan_chosen_stdout()
Today if CONFIG_OF_FLATTREE is not set then early_init_dt_scan_chosen_stdout() does not exist.
2. param_setup_earlycon()
Today we have 2 handlers for "earlycon" option. One (in fdt.c) is for the option without args,
and another (earlycon.c) always expects agrs. But both return 0 for the opposite cases becasue they
can not check what another hander returns.
Now we have just one handler and it can return correct value.
and now you return -ENODEV, did you
test this out?
On Thu, Mar 31, 2016 at 08:04:20PM +0300, Aleksey Makarov wrote:
On 03/31/2016 07:32 PM, Greg Kroah-Hartman wrote:
quoted
On Thu, Mar 31, 2016 at 04:40:23PM +0300, Aleksey Makarov wrote:
quoted
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
Signed-off-by: Leif Lindholm <redacted>
Signed-off-by: Aleksey Makarov <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
drivers/of/fdt.c | 11 +----------
drivers/tty/serial/earlycon.c | 2 +-
include/linux/of_fdt.h | 2 ++
3 files changed, 4 insertions(+), 11 deletions(-)
Doesn't this change the default logic? Today you are returning 0 if you
don't have this config option set,
I am not sure I understand this. Which return value do you mean?
1. early_init_dt_scan_chosen_stdout()
Today if CONFIG_OF_FLATTREE is not set then early_init_dt_scan_chosen_stdout() does not exist.
It "exists" in that you return -ENODEV, right? Look at the place where
you called this function, previously you returned 0, now you return this
function call's return value.
2. param_setup_earlycon()
Today we have 2 handlers for "earlycon" option. One (in fdt.c) is for the option without args,
and another (earlycon.c) always expects agrs. But both return 0 for the opposite cases becasue they
can not check what another hander returns.
Now we have just one handler and it can return correct value.
I don't understand.
quoted
and now you return -ENODEV, did you
test this out?
Yes, I tested it.
On what platforms? With what configurations?
thanks,
greg k-h
On Thu, Mar 31, 2016 at 08:04:20PM +0300, Aleksey Makarov wrote:
quoted
On 03/31/2016 07:32 PM, Greg Kroah-Hartman wrote:
quoted
On Thu, Mar 31, 2016 at 04:40:23PM +0300, Aleksey Makarov wrote:
quoted
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
Signed-off-by: Leif Lindholm <redacted>
Signed-off-by: Aleksey Makarov <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
drivers/of/fdt.c | 11 +----------
drivers/tty/serial/earlycon.c | 2 +-
include/linux/of_fdt.h | 2 ++
3 files changed, 4 insertions(+), 11 deletions(-)
Doesn't this change the default logic? Today you are returning 0 if you
don't have this config option set,
I am not sure I understand this. Which return value do you mean?
1. early_init_dt_scan_chosen_stdout()
Today if CONFIG_OF_FLATTREE is not set then early_init_dt_scan_chosen_stdout() does not exist.
It "exists" in that you return -ENODEV, right? Look at the place where
you called this function,
It's param_setup_earlycon() so see below for explanations.
previously you returned 0, now you return this
function call's return value.
quoted
2. param_setup_earlycon()
Today we have 2 handlers for "earlycon" option. One (in fdt.c) is for the option without args,
and another (earlycon.c) always expects agrs. But both return 0 for the opposite cases becasue they
can not check what another hander returns.
Now we have just one handler and it can return correct value.
I don't understand.
This patch deletes early_param("earlycon", setup_of_earlycon) from fdt.c and
keeps early_param("earlycon", param_setup_earlycon) in earlycon.c.
Assume "earlycon" kernel command line parameter was passed without arguments.
Before this patch:
early_init_dt_scan_chosen_stdout() is called from setup_of_earlycon()
where its return value is returned to parse_early_param()
After this patch:
early_init_dt_scan_chosen_stdout() is called from param_setup_earlycon()
so we should return its return value from param_setup_earlycon() if we want
to pass it to parse_early_param().
quoted
quoted
and now you return -ENODEV, did you
test this out?
Yes, I tested it.
On what platforms? With what configurations?
platform: QEMU
configuration options: with/without acpi, dt
command line options: with/without "earlycon", "earlycon=..."
Thank you
Aleksey Makarov
From: Peter Hurley <hidden> Date: 2016-04-04 21:07:42
On 03/31/2016 06:40 AM, Aleksey Makarov wrote:
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
From: Peter Hurley <hidden> Date: 2016-04-04 21:08:51
On 03/31/2016 06:40 AM, Aleksey Makarov wrote:
This patch adds function pl011_console_match() that implements
method match of struct console. It allows to match consoles against
data specified in a string, for example taken from command line or
compiled by ACPI SPCR table handler.
So for the code:
Reviewed-by: Peter Hurley <redacted>
However, I still have concerns regarding the license of this code
as GPL, when the Microsoft patent notice in [2] above only provides
two license options, neither of which are referred to in the
drivers/acpi/spcr.c file header and neither of which (I believe) are
GPL compatible.
@@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_EC_DEBUGFS) += ec_sys.oobj-$(CONFIG_ACPI_CUSTOM_METHOD)+=custom_method.oobj-$(CONFIG_ACPI_BGRT)+=bgrt.oobj-$(CONFIG_ACPI_CPPC_LIB)+=cppc_acpi.o+obj-$(CONFIG_ACPI_SPCR_TABLE)+=spcr.oobj-$(CONFIG_ACPI_DEBUGGER_USER)+=acpi_dbg.o# processor has its own "processor." module_param namespace
From: Mark Salter <hidden> Date: 2016-04-05 16:27:54
Could you CC me on future postings of this series, please?
So v3 fixed a problem where platforms using 8250 didn't work.
Then in v5, that fix was lost so 8250 no longer works.
--Mark
On Thu, 2016-03-31 at 16:40 +0300, Aleksey Makarov wrote:
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
Could you CC me on future postings of this series, please?
So v3 fixed a problem where platforms using 8250 didn't work.
Then in v5, that fix was lost so 8250 no longer works.
That fix was dropped because now this is implemented differently.
Now the code uses the existing match() member of struct console.
It has already been implemented for 8250.
Probably SPCR table specifies incorrect data.
It was reported that D02 board has similar issue.
Thank you
Aleksey Makarov
--Mark
On Thu, 2016-03-31 at 16:40 +0300, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
@@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_EC_DEBUGFS) += ec_sys.oobj-$(CONFIG_ACPI_CUSTOM_METHOD)+=custom_method.oobj-$(CONFIG_ACPI_BGRT)+=bgrt.oobj-$(CONFIG_ACPI_CPPC_LIB)+=cppc_acpi.o+obj-$(CONFIG_ACPI_SPCR_TABLE)+=spcr.oobj-$(CONFIG_ACPI_DEBUGGER_USER)+=acpi_dbg.o# processor has its own "processor." module_param namespace
On Wed, Apr 06, 2016 at 01:24:12PM +0300, Aleksey Makarov wrote:
On 04/05/2016 07:27 PM, Mark Salter wrote:
quoted
Could you CC me on future postings of this series, please?
So v3 fixed a problem where platforms using 8250 didn't work.
Then in v5, that fix was lost so 8250 no longer works.
That fix was dropped because now this is implemented differently.
Now the code uses the existing match() member of struct console.
It has already been implemented for 8250.
Probably SPCR table specifies incorrect data.
It was reported that D02 board has similar issue.
The D02 issue referred to is the 8250 implementation they used has 32bit
only MMIO access which there is no manner to represent in SPCR. It also
doesn't use the "standard" 16550 clock rate so supplying a baud rate
makes it change to a random baud rate.
We may need two 8250 subset entries, one just means no clock given, and
one no clock given + mmio32 only.
Graeme
Thank you
Aleksey Makarov
quoted
--Mark
On Thu, 2016-03-31 at 16:40 +0300, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
From: Mark Salter <hidden> Date: 2016-04-06 14:18:27
On Wed, 2016-04-06 at 11:52 +0100, Graeme Gregory wrote:
On Wed, Apr 06, 2016 at 01:24:12PM +0300, Aleksey Makarov wrote:
quoted
On 04/05/2016 07:27 PM, Mark Salter wrote:
quoted
Could you CC me on future postings of this series, please?
So v3 fixed a problem where platforms using 8250 didn't work.
Then in v5, that fix was lost so 8250 no longer works.
That fix was dropped because now this is implemented differently.
Now the code uses the existing match() member of struct console.
It has already been implemented for 8250.
Probably SPCR table specifies incorrect data.
It was reported that D02 board has similar issue.
The D02 issue referred to is the 8250 implementation they used has 32bit
only MMIO access which there is no manner to represent in SPCR. It also
doesn't use the "standard" 16550 clock rate so supplying a baud rate
makes it change to a random baud rate.
So, the problem with Mustang and m400 was the mmio vs mmio32. Right now,
the kernel only supports mmio32 in the 8250_dw.c driver when probed with
ACPI. Other x86 machines just use legacy 8250 ports which don't need
entries in the DSDT and use legacy io. The 8250_dw driver does support
non-standard clocks specified in the DSDT. That works fine for Mustang
and m400.
So with this quick hack, v7 is working with Mustang/m400:
@@ -71,6 +72,8 @@ int __init parse_spcr(bool earlycon)
case ACPI_DBG2_16550_COMPATIBLE:
case ACPI_DBG2_16550_SUBSET:
uart = "uart";
+ if (mmio)
+ iotype = "mmio32";
break;
default:
err = -ENOENT;
We may need two 8250 subset entries, one just means no clock given, and
one no clock given + mmio32 only.
Graeme
quoted
Thank you
Aleksey Makarov
quoted
--Mark
On Thu, 2016-03-31 at 16:40 +0300, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Peter Hurley <hidden> Date: 2016-04-06 16:27:37
On 04/06/2016 07:18 AM, Mark Salter wrote:
On Wed, 2016-04-06 at 11:52 +0100, Graeme Gregory wrote:
quoted
On Wed, Apr 06, 2016 at 01:24:12PM +0300, Aleksey Makarov wrote:
quoted
On 04/05/2016 07:27 PM, Mark Salter wrote:
quoted
Could you CC me on future postings of this series, please?
So v3 fixed a problem where platforms using 8250 didn't work.
Then in v5, that fix was lost so 8250 no longer works.
That fix was dropped because now this is implemented differently.
Now the code uses the existing match() member of struct console.
It has already been implemented for 8250.
Probably SPCR table specifies incorrect data.
It was reported that D02 board has similar issue.
The D02 issue referred to is the 8250 implementation they used has 32bit
only MMIO access which there is no manner to represent in SPCR. It also
doesn't use the "standard" 16550 clock rate so supplying a baud rate
makes it change to a random baud rate.
So, the problem with Mustang and m400 was the mmio vs mmio32.
Bummer. Maybe that firmware can use a different DBG2 port designation to
indicate it's a DesignWare 8250 (or generically 32-bit mmio).
Right now,
the kernel only supports mmio32 in the 8250_dw.c driver when probed with
ACPI.
While that's true specifically for DesignWare 8250 + ACPI, that's not
true for _all_ 8250 + ACPI.
Other x86 machines just use legacy 8250 ports which don't need
entries in the DSDT and use legacy io.
I find that statement hard to believe. I know for a fact ia64 servers didn't,
so the assertion that SPCR + 16550 + MMIO automatically means 32-bit data width
seems unlikely.
In fact, I suspect the opposite is true; that before these arm64 designs,
SPCR + 16550 + MMIO automatically meant 8-bit data width, which is why it's
unspecified in the SPCR table.
Regards,
Peter Hurley
quoted hunk
The 8250_dw driver does support
non-standard clocks specified in the DSDT. That works fine for Mustang
and m400.
So with this quick hack, v7 is working with Mustang/m400:
@@ -37,6 +37,7 @@ int __init parse_spcr(bool earlycon)acpi_statusstatus;char*uart;char*iotype;+intmmio;intbaud_rate;interr;
@@ -56,8 +57,8 @@ int __init parse_spcr(bool earlycon)gotodone;}-iotype=table->serial_port.space_id==ACPI_ADR_SPACE_SYSTEM_MEMORY?-"mmio":"io";+mmio=table->serial_port.space_id==ACPI_ADR_SPACE_SYSTEM_MEMORY;+iotype=mmio?"mmio":"io";switch(table->interface_type){caseACPI_DBG2_ARM_SBSA_32BIT:
@@ -71,6 +72,8 @@ int __init parse_spcr(bool earlycon)caseACPI_DBG2_16550_COMPATIBLE:caseACPI_DBG2_16550_SUBSET:uart="uart";+if(mmio)+iotype="mmio32";break;default:err=-ENOENT;
quoted
We may need two 8250 subset entries, one just means no clock given, and
one no clock given + mmio32 only.
Graeme
quoted
Thank you
Aleksey Makarov
quoted
--Mark
On Thu, 2016-03-31 at 16:40 +0300, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
From: Mark Salter <hidden> Date: 2016-04-06 19:00:20
On Wed, 2016-04-06 at 09:27 -0700, Peter Hurley wrote:
On 04/06/2016 07:18 AM, Mark Salter wrote:
quoted
On Wed, 2016-04-06 at 11:52 +0100, Graeme Gregory wrote:
quoted
On Wed, Apr 06, 2016 at 01:24:12PM +0300, Aleksey Makarov wrote:
quoted
On 04/05/2016 07:27 PM, Mark Salter wrote:
quoted
Could you CC me on future postings of this series, please?
So v3 fixed a problem where platforms using 8250 didn't work.
Then in v5, that fix was lost so 8250 no longer works.
That fix was dropped because now this is implemented differently.
Now the code uses the existing match() member of struct console.
It has already been implemented for 8250.
Probably SPCR table specifies incorrect data.
It was reported that D02 board has similar issue.
The D02 issue referred to is the 8250 implementation they used has 32bit
only MMIO access which there is no manner to represent in SPCR. It also
doesn't use the "standard" 16550 clock rate so supplying a baud rate
makes it change to a random baud rate.
So, the problem with Mustang and m400 was the mmio vs mmio32.
Bummer. Maybe that firmware can use a different DBG2 port designation to
indicate it's a DesignWare 8250 (or generically 32-bit mmio).
quoted
Right now,
the kernel only supports mmio32 in the 8250_dw.c driver when probed with
ACPI.
While that's true specifically for DesignWare 8250 + ACPI, that's not
true for _all_ 8250 + ACPI.
quoted
Other x86 machines just use legacy 8250 ports which don't need
entries in the DSDT and use legacy io.
I find that statement hard to believe. I know for a fact ia64 servers didn't,
so the assertion that SPCR + 16550 + MMIO automatically means 32-bit data width
seems unlikely.
You're right. Other than DesignWare, 8250 ports can be descibed with PNP IDs
which is the bit I was missing. And all of those assume 8-bit width. So it
seems a DBG2 port designation for 8250 with 32-bit mmio is needed.
In fact, I suspect the opposite is true; that before these arm64 designs,
SPCR + 16550 + MMIO automatically meant 8-bit data width, which is why it's
unspecified in the SPCR table.
Regards,
Peter Hurley
quoted
The 8250_dw driver does support
non-standard clocks specified in the DSDT. That works fine for Mustang
and m400.
So with this quick hack, v7 is working with Mustang/m400:
@@ -71,6 +72,8 @@ int __init parse_spcr(bool earlycon)
case ACPI_DBG2_16550_COMPATIBLE:
case ACPI_DBG2_16550_SUBSET:
uart = "uart";
+ if (mmio)
+ iotype = "mmio32";
break;
default:
err = -ENOENT;
quoted
We may need two 8250 subset entries, one just means no clock given, and
one no clock given + mmio32 only.
Graeme
quoted
Thank you
Aleksey Makarov
quoted
--Mark
On Thu, 2016-03-31 at 16:40 +0300, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Move "earlycon" early_param handling to earlycon.c to parse this option once
*** PATCH "ACPICA: Headers: Add new constants for the DBG2 ACPI table"
*** IS JUST TO ENABLE BUILDING THE PATCHSET ON linux-next
Patch "ACPICA: Headers: Add new constants for the DBG2 ACPI table" is required
for the next patch. It is taken from ACPICA series [3], but it has not appeared
in linux-next yet.
Parse SPCR table, setup earlycon and add register specified console.
Enable parsing this table on ARM64. Earlycon should be set up
as early as possible. ACPI boot tables are mapped in
arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
and that's where we parse spcr. So it has to be opted-in per-arch.
Implement console_match() for pl011.
Based on the work by Leif Lindholm [4]
Thanks to Peter Hurley for explaining how this should work.
Should be applied to next-20160331.
Tested on QEMU. SPCR support is included in QEMU's ARM mach-virt
since 2.4 release.
v7:
- add Acked-by: Rob Herring for "of/serial: move earlycon early_param handling
to serial"
- call DT earlycon initialization from the arch ACPI code, not from parse_spcr()
(Rafael J. Wysocki)
- fix a few minor issues (Rafael J. Wysocki)
v6:
https://lkml.kernel.org/g/1458823925-19560-1-git-send-email-aleksey.makarov@linaro.org
- add documentation for parse_spcr() functioin (Yury Norov)
- don't initialize err variable (Yury Norov)
- add __initdata for the earlycon_init_is_deferred flag variable
- rename the function exported in "of/serial: move earlycon early_param handling
to serial" to avoid clash with the function from arch/microblaze/kernel/prom.c
- defer initialization of DT earlycon until DT/ACPI decision is made
(Rob Herring, Peter Hurley)
- use snprintf instead of sprintf (Andy Shevchenko)
- drop patch that adds EARLYCON_DECLARE for pl011 as EARLYCON_DECLARE is
equivalent to OF_EARLYCON_DECLARE for 4.6+ (Peter Hurley). This means that
SPCR earlycon will not work on the kernels before 4.6
v5:
https://lkml.kernel.org/g/1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "serial: pl011: use ACPI SPCR to setup 32-bit access" because
it is ugly. Also because Christopher Covington came with a better solution [5]
- remove error message when the table is not provided by ACPI (Andy Shevchenko)
- rewrite spcr.c following the suggestions by Peter Hurley
- add console_match() for pl011 in a separate patch
- add EARLYCON_DECLARE for pl011 in a separate patch
- add patch "of/serial: move earlycon early_param handling to serial" from
the GDB2 series
v4:
https://lkml.kernel.org/g/1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org
- drop patch "ACPI: change __init to __ref for early_acpi_os_unmap_memory()"
ACPI developers work on a new API and asked not to do that.
Instead, use acpi_get_table_with_size()/early_acpi_os_unmap_memory() once
and cache the result. (Lv Zheng)
- fix some style issues (Yury Norov)
v3:
https://lkml.kernel.org/g/1455559532-8305-1-git-send-email-aleksey.makarov@linaro.org
Greg Kroah-Hartman did not like v2 so I have rewritten this patchset:
- drop acpi_match() member of struct console
- drop implementations of this member for pl011 and 8250
- drop the patch that renames some vars in printk.c as it is not needed anymore
- drop patch that introduces system wide acpi_table_parse2().
Instead introduce a custom acpi_table_parse_spcr() in spcr.c
Instead of introducing a new match_acpi() member of struct console,
this patchset introduces a new function acpi_console_check().
This function is called when a new uart is registered at serial_core.c
the same way OF code checks for console. If the registered uart is the
console specified by SPCR table, this function calls add_preferred_console()
The restrictions of this approach are:
- only serial consoles can be set up
- only consoles specified by the memory/io address can be set up
(SPCR can specify devices by PCI id/PCI address)
v2:
https://lkml.kernel.org/g/1455299022-11641-1-git-send-email-aleksey.makarov@linaro.org
- don't use SPCR if user specified console in command line
- fix initialization order of newcon->index = 0
- rename some variables at printk.c (Joe Perches, Peter Hurley)
- enable ACPI_SPCR_TABLE in a separate patch (Andy Shevchenko)
- remove the retry loop for console registering (Peter Hurley).
Instead, obtain SPCR with acpi_get_table(). That works after
call to acpi_early_init() i. e. in any *_initcall()
- describe design decision behind introducing acpi_match() (Peter Hurley)
- fix compilation for x86 + ACPI (Graeme Gregory)
- introduce DBG2 constants in a separate patch (Andy Shevchenko)
- fix a typo in DBG2 constants (Andy Shevchenko)
- add ACPI_DBG2_ARM_SBSA_32BIT constant (Christopher Covington)
- add support for ACPI_DBG2_ARM_SBSA_* consoles (Christopher Covington)
- add documentation for functions
- add a patch that uses SPCR to find if SBSA serial driver should use 32-bit
accessor functions (Christopher Covington)
- change __init to __ref for early_acpi_os_unmap_memory() in a separate patch
- introduce acpi_table_parse2() in a separate patch
- fix fetching the SPCR table early (Mark Salter)
- add a patch from Mark Salter that introduces support for matching 8250-based
consoles
v1:
https://lkml.kernel.org/g/1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html
[2] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
[3] https://lkml.kernel.org/g/cover.1458714002.git.lv.zheng@intel.com
[4] https://lkml.kernel.org/g/1441716217-23786-1-git-send-email-leif.lindholm@linaro.org
[5] https://lkml.kernel.org/g/1457415800-8799-1-git-send-email-cov@codeaurora.org
Aleksey Makarov (4):
ACPICA: Headers: Add new constants for the DBG2 ACPI table
ACPI: parse SPCR and enable matching console
ARM64: ACPI: enable ACPI_SPCR_TABLE
serial: pl011: add console matching function
Leif Lindholm (1):
of/serial: move earlycon early_param handling to serial
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/acpi.c | 11 +++-
drivers/acpi/Kconfig | 3 ++
drivers/acpi/Makefile | 1 +
drivers/acpi/spcr.c | 111 ++++++++++++++++++++++++++++++++++++++++
drivers/of/fdt.c | 11 +---
drivers/tty/serial/amba-pl011.c | 56 ++++++++++++++++++++
drivers/tty/serial/earlycon.c | 19 ++++++-
include/acpi/actbl2.h | 7 ++-
include/linux/acpi.h | 6 +++
include/linux/of_fdt.h | 2 +
include/linux/serial_core.h | 6 +++
12 files changed, 220 insertions(+), 14 deletions(-)
create mode 100644 drivers/acpi/spcr.c
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 31, 2016 at 04:40:23PM +0300, Aleksey Makarov wrote:
From: Leif Lindholm <redacted>
We have multiple "earlycon" early_param handlers - merge the DT one into
the main earlycon one. It's a cleanup that also will be useful
to defer setting up DT console until ACPI/DT decision is made.
Rename the exported function to avoid clashing with the function from
arch/microblaze/kernel/prom.c
Signed-off-by: Leif Lindholm <redacted>
Signed-off-by: Aleksey Makarov <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
drivers/of/fdt.c | 11 +----------
drivers/tty/serial/earlycon.c | 2 +-
include/linux/of_fdt.h | 2 ++
3 files changed, 4 insertions(+), 11 deletions(-)
On Thu, Mar 31, 2016 at 04:40:27PM +0300, Aleksey Makarov wrote:
This patch adds function pl011_console_match() that implements
method match of struct console. It allows to match consoles against
data specified in a string, for example taken from command line or
compiled by ACPI SPCR table handler.
Signed-off-by: Aleksey Makarov <redacted>
---
drivers/tty/serial/amba-pl011.c | 56 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
From: Jon Masters <hidden> Date: 2016-05-12 08:20:46
On 03/31/2016 09:40 AM, Aleksey Makarov wrote:
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Hi Aleksey,
Can you summarize the status of this patch series?
Jon.
Hi Jon,
In v7 I addressed the issues that were brought up by Rafael J . Wysocki
(but I still do not have ACK from ACPI people).
The issue with D02 will be addressed in a separate patch.
There possibly is an issue with 16550 and command line console with I am
investigating and probably will address in a separate patch.
I know no other problems with it and reviewers seem happy.
So I believe this patchset could be pulled. If needed, I will send v8.
Thank you
Aleksey Makarov
On 05/12/2016 11:20 AM, Jon Masters wrote:
On 03/31/2016 09:40 AM, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Hi Aleksey,
Can you summarize the status of this patch series?
Jon.
From: Kefeng Wang <hidden> Date: 2016-05-12 13:09:23
On 2016/5/12 19:52, Aleksey Makarov wrote:
Hi Jon,
In v7 I addressed the issues that were brought up by Rafael J . Wysocki
(but I still do not have ACK from ACPI people).
The issue with D02 will be addressed in a separate patch.
There possibly is an issue with 16550 and command line console with I am
investigating and probably will address in a separate patch.
Sound good, and will retest this in D02 with the coming patch, and
Tested-by: Kefeng Wang <redacted>
BRs,
Kefeng
I know no other problems with it and reviewers seem happy.
So I believe this patchset could be pulled. If needed, I will send v8.
Thank you
Aleksey Makarov
On 05/12/2016 11:20 AM, Jon Masters wrote:
quoted
On 03/31/2016 09:40 AM, Aleksey Makarov wrote:
quoted
'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
Console Redirection Table) [2] as a mandatory ACPI table that
specifies the configuration of serial console.
Hi Aleksey,
Can you summarize the status of this patch series?
Jon.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.