[PATCH] serial:ifx6x60:Delete SPI timer when shut down port

Subsystems: the rest, tty layer and serial drivers

STALE5006d

2 messages, 2 authors, 2012-11-26 · open the first message on its own page

[PATCH] serial:ifx6x60:Delete SPI timer when shut down port

From: chao bi <hidden>
Date: 2012-11-23 01:19:05

When shut down SPI port, it's possible that MRDY has been asserted and a SPI
timer was activated waiting for SRDY assert, in the case, it needs to delete
this timer.

Signed-off-by: Chen Jun <redacted>
Signed-off-by: channing <redacted>
---
 drivers/tty/serial/ifx6x60.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 5b9bc19..f5e9666 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -552,6 +552,7 @@ static void ifx_port_shutdown(struct tty_port *port)
 		container_of(port, struct ifx_spi_device, tty_port);
 
 	mrdy_set_low(ifx_dev);
+	del_timer(&ifx_dev->spi_timer);
 	clear_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags);
 	tasklet_kill(&ifx_dev->io_work_tasklet);
 }
-- 
1.7.1

Re: [PATCH] serial:ifx6x60:Delete SPI timer when shut down port

From: Greg KH <hidden>
Date: 2012-11-26 23:45:57

On Fri, Nov 23, 2012 at 09:33:33AM +0800, chao bi wrote:
When shut down SPI port, it's possible that MRDY has been asserted and a SPI
timer was activated waiting for SRDY assert, in the case, it needs to delete
this timer.
This doesn't apply without fuzz, so I don't know what tree you are
working against here.

Please redo it against the latest version of the tty-next tree.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help