[PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950

Subsystems: 8250/16?50 (and clone uarts) serial driver, pci subsystem, the rest, tty layer and serial drivers

STALE5098d

2 messages, 2 authors, 2012-09-21 · open the first message on its own page

[PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950

From: Flavio Leitner <hidden>
Date: 2012-09-17 18:54:13

Apparently the same card model has two IDs, so this patch
complements the commit 39aced68d664291db3324d0fcf0985ab5626aac2
adding the missing one.

Signed-off-by: Flavio Leitner <redacted>
---
 drivers/tty/serial/8250/8250_pci.c | 7 +++++--
 include/linux/pci_ids.h            | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 28e7c7c..6fe88e6 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3232,8 +3232,11 @@ static struct pci_device_id serial_pci_tbl[] = {
 		 * For now just used the hex ID 0x950a.
 		 */
 	{	PCI_VENDOR_ID_OXSEMI, 0x950a,
-		PCI_SUBVENDOR_ID_SIIG, PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL, 0, 0,
-		pbn_b0_2_115200 },
+		PCI_SUBVENDOR_ID_SIIG, PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_00,
+		0, 0, pbn_b0_2_115200 },
+	{	PCI_VENDOR_ID_OXSEMI, 0x950a,
+		PCI_SUBVENDOR_ID_SIIG, PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_30,
+		0, 0, pbn_b0_2_115200 },
 	{	PCI_VENDOR_ID_OXSEMI, 0x950a,
 		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
 		pbn_b0_2_1130000 },
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 6b4565c..4242013 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -1847,7 +1847,8 @@
 #define PCI_DEVICE_ID_SIIG_8S_20x_650	0x2081
 #define PCI_DEVICE_ID_SIIG_8S_20x_850	0x2082
 #define PCI_SUBDEVICE_ID_SIIG_QUARTET_SERIAL	0x2050
-#define PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL	0x2530
+#define PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_00	0x2500
+#define PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_30	0x2530
 
 #define PCI_VENDOR_ID_RADISYS		0x1331
 
-- 
1.7.11.4

Re: [PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950

From: Greg KH <hidden>
Date: 2012-09-21 19:47:14

On Mon, Sep 17, 2012 at 03:53:41PM -0300, Flavio Leitner wrote:
Apparently the same card model has two IDs, so this patch
complements the commit 39aced68d664291db3324d0fcf0985ab5626aac2
adding the missing one.

Signed-off-by: Flavio Leitner <redacted>
---
 drivers/tty/serial/8250/8250_pci.c | 7 +++++--
 include/linux/pci_ids.h            | 3 ++-
Please read the top of the pci_ids.h file for why we don't want to add
new entries there.

Please fix that up and resend this.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help