# Re: \[PATCH v2 11/27\] selftests/landlock: Assert helper results that are used afterwards

- From: sashiko-bot@kernel.org
- Date: 2026-11-04 21:14:33 
- List: linux-security-module
- Page: https://ratatoskr.run/linux-security-module/2026/11/17864692
- Thread: https://ratatoskr.run/linux-security-module/2026/11/17864489/t.md

```text
> Some helpers check a result with EXPECT_*() and then use it:
> cap_get_proc() in _init_caps() and _change_cap(), and
> landlock_create_ruleset() in drop_access_rights(), create_domain() and
> create_fs_domain().  On failure they pass NULL or -1 to the next calls,
> which then fail with misleading messages.
> 
> Use ASSERT_*() for these checks, as create_scoped_domain() already does.
> 
> Signed-off-by: Günther Noack <redacted>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-selftests-refactor-v2-0-c52f23f7ce33@gmail.com?part=11

```