Re: [PATCH v2 1/6] landlock: Increment Landlock ABI version to 4
From: Mickaël Salaün <mic@digikod.net>
Date: 2023-07-12 10:55:44
Also in:
linux-fsdevel
This patch should be squashed with 2/6 (LANDLOCK_ACCESS_FS_IOCTL). Please take into account my previous review from the initial RFC, for this patch and the next ones. On 23/06/2023 16:43, Günther Noack wrote:
quoted hunk ↗ jump to hunk
Increment the Landlock ABI version in preparation for the ioctl feature. Signed-off-by: Günther Noack <gnoack@google.com> --- security/landlock/syscalls.c | 2 +- tools/testing/selftests/landlock/base_test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/security/landlock/syscalls.c b/security/landlock/syscalls.c index 245cc650a4dc..c70fc9e6fe9e 100644 --- a/security/landlock/syscalls.c +++ b/security/landlock/syscalls.c@@ -129,7 +129,7 @@ static const struct file_operations ruleset_fops = { .write = fop_dummy_write, }; -#define LANDLOCK_ABI_VERSION 3 +#define LANDLOCK_ABI_VERSION 4 /** * sys_landlock_create_ruleset - Create a new rulesetdiff --git a/tools/testing/selftests/landlock/base_test.c b/tools/testing/selftests/landlock/base_test.c index 792c3f0a59b4..646f778dfb1e 100644 --- a/tools/testing/selftests/landlock/base_test.c +++ b/tools/testing/selftests/landlock/base_test.c@@ -75,7 +75,7 @@ TEST(abi_version) const struct landlock_ruleset_attr ruleset_attr = { .handled_access_fs = LANDLOCK_ACCESS_FS_READ_FILE, }; - ASSERT_EQ(3, landlock_create_ruleset(NULL, 0, + ASSERT_EQ(4, landlock_create_ruleset(NULL, 0, LANDLOCK_CREATE_RULESET_VERSION)); ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr, 0,