[PATCH] ima/evm: mark evm_fixmode as __ro_after_init

Subsystems: extended verification module (evm), integrity measurement architecture (ima), security subsystem, the rest

STALE1743d

3 messages, 2 authors, 2021-10-28 · open the first message on its own page

[PATCH] ima/evm: mark evm_fixmode as __ro_after_init

From: Austin Kim <hidden>
Date: 2021-10-26 22:44:11

From: Austin Kim <redacted>

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.

Signed-off-by: Austin Kim <redacted>
---
 security/integrity/evm/evm_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
index 1c8435dfabee..08f907382c61 100644
--- a/security/integrity/evm/evm_main.c
+++ b/security/integrity/evm/evm_main.c
@@ -78,7 +78,7 @@ static struct xattr_list evm_config_default_xattrnames[] = {
 
 LIST_HEAD(evm_config_xattrnames);
 
-static int evm_fixmode;
+static int evm_fixmode __ro_after_init;
 static int __init evm_set_fixmode(char *str)
 {
 	if (strncmp(str, "fix", 3) == 0)
-- 
2.20.1

Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init

From: Mimi Zohar <zohar@linux.ibm.com>
Date: 2021-10-28 00:27:29

Hi Austin,

The subject line should be just "evm:".

On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
From: Austin Kim <redacted>

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.
Please properly format the text.  From
Documentation/process/submitting-patches.rst:

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.
Signed-off-by: Austin Kim <redacted>
Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init

From: Austin Kim <hidden>
Date: 2021-10-28 01:48:58

Hello Mimi,

2021년 10월 28일 (목) 오전 9:27, Mimi Zohar [off-list ref]님이 작성:
Hi Austin,

The subject line should be just "evm:".

On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
quoted
From: Austin Kim <redacted>

evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.
Please properly format the text.  From
Documentation/process/submitting-patches.rst:

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.
Thanks for feedback.
let me resend the patch after updating "subject line" and checking text-format.

BR,
Austin Kim
quoted
Signed-off-by: Austin Kim <redacted>
Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help