[PATCH] integrity/ima: Add declarations to init_once void arguments.

init_once is a callback to kmem_cache_create. The parameter
type of this function is void *, so it's better to give a
explicit cast here.

Signed-off-by: Jiele Zhao <redacted>
---
 security/integrity/iint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 1d20003243c3..5f3f2de997e1 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c

@@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
 
 static void init_once(void *foo)
 {
-	struct integrity_iint_cache *iint = foo;
+	struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
 
 	memset(iint, 0, sizeof(*iint));
 	iint->ima_file_status = INTEGRITY_UNKNOWN;

-- 
2.25.1

Ping.

On 2021/3/23 9:33, Jiele Zhao wrote:

Ping.

On 2021/3/23 9:33, Jiele Zhao wrote:

On Tue, 6 Apr 2021, Jiele Zhao wrote:

Ping.

Mimi Zohar is the maintainer for this code.

On 2021/3/23 9:33, Jiele Zhao wrote:

quoted

init_once is a callback to kmem_cache_create. The parameter
type of this function is void *, so it's better to give a
explicit cast here.

Signed-off-by: Jiele Zhao <redacted>
---
  security/integrity/iint.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 1d20003243c3..5f3f2de997e1 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c

@@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
  
  static void init_once(void *foo)
  {
-	struct integrity_iint_cache *iint = foo;
+	struct integrity_iint_cache *iint = (struct integrity_iint_cache

*)foo;
  
   memset(iint, 0, sizeof(*iint));
   iint->ima_file_status = INTEGRITY_UNKNOWN;

-- 
James Morris
[off-list ref]

Hi Mimi,

Please see if this is a useful suggestion.

On 2021/4/6 10:38, James Morris wrote:

On Tue, 6 Apr 2021, Jiele Zhao wrote:

quoted

Ping.

Mimi Zohar is the maintainer for this code.

quoted

On 2021/3/23 9:33, Jiele Zhao wrote:

quoted

init_once is a callback to kmem_cache_create. The parameter
type of this function is void *, so it's better to give a
explicit cast here.

Signed-off-by: Jiele Zhao <redacted>
---
   security/integrity/iint.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 1d20003243c3..5f3f2de997e1 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c

@@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
   
   static void init_once(void *foo)
   {
-	struct integrity_iint_cache *iint = foo;
+	struct integrity_iint_cache *iint = (struct integrity_iint_cache

*)foo;
   
    memset(iint, 0, sizeof(*iint));
    iint->ima_file_status = INTEGRITY_UNKNOWN;

Hi Jiele,

On Tue, 2021-03-23 at 01:33 +0000, Jiele Zhao wrote:

init_once is a callback to kmem_cache_create. The parameter
type of this function is void *, so it's better to give a
explicit cast here.

Signed-off-by: Jiele Zhao <redacted>

Please remove the "ima" in the Subject line and re-post Cc'ing the
linux-integrity mailing list.

Like the other init_once() examples, please add a blank before foo.

thanks,

Mimi

 	memset(iint, 0, sizeof(*iint));
 	iint->ima_file_status = INTEGRITY_UNKNOWN;