[PATCH] KEYS: trusted: tee: fix build error due to missing include

Subsystems: keys-trusted, keys-trusted-tee, keys/keyrings, security subsystem, the rest

STALE1974d

3 messages, 2 authors, 2021-03-18 · open the first message on its own page

[PATCH] KEYS: trusted: tee: fix build error due to missing include

From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: 2021-03-17 14:31:04

MODULE_DEVICE_TABLE is defined in <linux/module.h>, which is not
included. Add the include to fix the build error its lack caused.

Cc: Sumit Garg <redacted>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 security/keys/trusted-keys/trusted_tee.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/security/keys/trusted-keys/trusted_tee.c b/security/keys/trusted-keys/trusted_tee.c
index 62983d98a252..2ce66c199e1d 100644
--- a/security/keys/trusted-keys/trusted_tee.c
+++ b/security/keys/trusted-keys/trusted_tee.c
@@ -8,6 +8,7 @@
 
 #include <linux/err.h>
 #include <linux/key-type.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/tee_drv.h>
-- 
2.29.2

Re: [PATCH] KEYS: trusted: tee: fix build error due to missing include

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-03-17 21:58:56

On Wed, Mar 17, 2021 at 03:29:05PM +0100, Ahmad Fatoum wrote:
MODULE_DEVICE_TABLE is defined in <linux/module.h>, which is not
included. Add the include to fix the build error its lack caused.

Cc: Sumit Garg <redacted>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Hi, I appreciate your work, thanks for taking action, but unfortunately
I already incorporated this fix to the original patch.

/Jarkko

Re: [PATCH] KEYS: trusted: tee: fix build error due to missing include

From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: 2021-03-18 07:07:37

Hi Jarkko,

On 17.03.21 22:57, Jarkko Sakkinen wrote:
On Wed, Mar 17, 2021 at 03:29:05PM +0100, Ahmad Fatoum wrote:
quoted
MODULE_DEVICE_TABLE is defined in <linux/module.h>, which is not
included. Add the include to fix the build error its lack caused.

Cc: Sumit Garg <redacted>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Hi, I appreciate your work, thanks for taking action, but unfortunately
I already incorporated this fix to the original patch.
Nothing unfortunate about this! :)

Cheers,
Ahmad
/Jarkko
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help