[PATCH] ima: Fix function name error in comment.

Subsystems: extended verification module (evm), integrity measurement architecture (ima), security subsystem, the rest

STALE1955d

3 messages, 2 authors, 2021-03-31 · open the first message on its own page

[PATCH] ima: Fix function name error in comment.

From: Jiele Zhao <hidden>
Date: 2021-03-23 09:20:00

Function "ima_file_check" is written as "ima_path_check" in
the comment. Fix this error to prevent misunderstanding.

Signed-off-by: Jiele Zhao <redacted>
---
 security/integrity/ima/ima_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9ef748ea829f..03bef720ab44 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -482,7 +482,7 @@ int ima_bprm_check(struct linux_binprm *bprm)
 }
 
 /**
- * ima_path_check - based on policy, collect/store measurement.
+ * ima_file_check - based on policy, collect/store measurement.
  * @file: pointer to the file to be measured
  * @mask: contains MAY_READ, MAY_WRITE, MAY_EXEC or MAY_APPEND
  *
-- 
2.25.1

Re: [PATCH] ima: Fix function name error in comment.

From: Mimi Zohar <zohar@linux.ibm.com>
Date: 2021-03-23 12:47:35

Hi Jiele,

On Tue, 2021-03-23 at 09:19 +0000, Jiele Zhao wrote:
Function "ima_file_check" is written as "ima_path_check" in
the comment. Fix this error to prevent misunderstanding.

Signed-off-by: Jiele Zhao <redacted>
The original function name was ima_path_check().  The policy parsing
still supports PATH_CHECK.   Commit 9bbb6cad0173 ("ima: rename
ima_path_check to ima_file_check") renamed the function to
ima_file_check(), but missed modifying the function name in the
comment.

Please update this patch description accordingly and add the "Fixes"
tag.

thanks,

Mimi

Re: [PATCH] ima: Fix function name error in comment.

From: Jiele Zhao <hidden>
Date: 2021-03-31 01:27:17

Ping.

On 2021/3/23 17:19, Jiele Zhao wrote:
quoted hunk
Function "ima_file_check" is written as "ima_path_check" in
the comment. Fix this error to prevent misunderstanding.

Signed-off-by: Jiele Zhao <redacted>
---
  security/integrity/ima/ima_main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9ef748ea829f..03bef720ab44 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -482,7 +482,7 @@ int ima_bprm_check(struct linux_binprm *bprm)
  }
  
  /**
- * ima_path_check - based on policy, collect/store measurement.
+ * ima_file_check - based on policy, collect/store measurement.
   * @file: pointer to the file to be measured
   * @mask: contains MAY_READ, MAY_WRITE, MAY_EXEC or MAY_APPEND
   *
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help