# Re: \[PATCH v40 11/24\] x86/sgx: Add SGX misc driver interface

- From: Borislav Petkov \<bp@alien8.de\>
- Date: 2020-11-06 17:09:39 
- List: linux-security-module
- Page: https://ratatoskr.run/linux-security-module/2020/11/6167284
- Thread: https://ratatoskr.run/linux-security-module/2020/11/6163987/t.md

```text
On Fri, Nov 06, 2020 at 06:07:42PM +0200, Jarkko Sakkinen wrote:
> On Thu, Nov 05, 2020 at 07:10:47PM +0100, Borislav Petkov wrote:
> > On Thu, Nov 05, 2020 at 07:57:45PM +0200, Jarkko Sakkinen wrote:
> > > I'll rather send a full patch set if required.
> > 
> > Why if the changes all belong to this patch and why should I take a
> > patch which clearly needs improving?
> > 
> > Just send the fixed version of this and I can take it now.
> > 
> > Thx.
> 
> Here's an update patch. I kept the name as sgx_encl_find() so and output
> argument instead of return value, so that the change is localized. I
> think this is good enough, i.e. the semantically obsolete stuff has been
> wiped off.

Thanks.

> Tested-by: Jethro Beekman <redacted>
> Tested-by: Haitao Huang <redacted>
> Tested-by: Chunyang Hui <redacted>
> Tested-by: Jordan Hand <redacted>
> Tested-by: Nathaniel McCallum <redacted>
> Tested-by: Seth Moore <redacted>
> Tested-by: Darren Kenny <redacted>

Btw, you do know that when you change the patch, those tested-by's don't
hold true anymore, right?

The Reviewed-by's too, actually.

I'll zap them.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
```
