# Re: \[PATCH 04/11\] iov\_iter: explicitly check for CHECK\_IOVEC\_ONLY in rw\_copy\_check\_uvector

- From: Al Viro \<viro@zeniv.linux.org.uk\>
- Date: 2020-09-21 15:07:59 
- List: linux-security-module
- Page: https://ratatoskr.run/linux-security-module/2020/09/189279
- Thread: https://ratatoskr.run/linux-arm-kernel/2020/09/189245/t.md

```text
On Mon, Sep 21, 2020 at 04:34:27PM +0200, Christoph Hellwig wrote:
> Explicitly check for the magic value insted of implicitly relying on
> its numeric representation.   Also drop the rather pointless unlikely
> annotation.

See above - I would rather have CHECK_IOVEC_ONLY gone.

The reason for doing these access_ok() in the same loop is fairly weak,
especially since you are checking type on each iteration.  Might as
well do that in a separate loop afterwards.
```
