# Re: \[PATCH v33 11/21\] x86/sgx: Linux Enclave Driver

- From: Jarkko Sakkinen \<hidden\>
- Date: 2020-07-03 23:04:36 
- List: linux-security-module
- Page: https://ratatoskr.run/linux-security-module/2020/07/6024995
- Thread: https://ratatoskr.run/linux-security-module/2020/06/6002919/t.md

```text
On Fri, Jun 26, 2020 at 04:20:19PM +0200, Borislav Petkov wrote:
> On Fri, Jun 26, 2020 at 07:16:27AM -0700, Sean Christopherson wrote:
> > That being said, I agree that it would be safer to move sgx_calc_ssaframesize()
> > inside sgx_validate_secs() and only compute encl_size after the secs is
> > validated.
> 

Changed as

if (!secs->ssa_frame_size)
	return -EINVAL;

if (sgx_calc_ssa_frame_size(secs->miscselect, secs->xfrm) >
    secs->ssa_frame_size)
	return -EINVAL;

/Jarkko
```
