# Re: \[PATCH V40 04/29\] lockdown: Enforce module signatures if the kernel is locked down

- From: David Howells \<dhowells@redhat.com\>
- Date: 2019-08-30 16:31:17 
- List: linux-security-module
- Page: https://ratatoskr.run/linux-security-module/2019/08/5704736
- Thread: https://ratatoskr.run/linux-security-module/2019/08/5692359/t.md

```text
Matthew Garrett [ref] wrote:

>  enum lockdown_reason {
>  	LOCKDOWN_NONE,
> +	LOCKDOWN_MODULE_SIGNATURE,
>  	LOCKDOWN_INTEGRITY_MAX,
>  	LOCKDOWN_CONFIDENTIALITY_MAX,
>  };

Aren't you mixing disjoint sets?

> +	[LOCKDOWN_MODULE_SIGNATURE] = "unsigned module loading",

Wouldn't it be better to pass this string as a parameter to
security_locked_down()?

David
```
