# Re: \[PATCH V40 03/29\] security: Add a static lockdown policy LSM

- From: David Howells \<dhowells@redhat.com\>
- Date: 2019-08-30 16:28:29 
- List: linux-security-module
- Page: https://ratatoskr.run/linux-security-module/2019/08/5704734
- Thread: https://ratatoskr.run/linux-security-module/2019/08/5692359/t.md

```text
Matthew Garrett [ref] wrote:

> +static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = {

const char *const maybe?

> +static enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE,
> +						 LOCKDOWN_INTEGRITY_MAX,
> +						 LOCKDOWN_CONFIDENTIALITY_MAX};
> +

const?

Isn't this also a 1:1 mapping?

> +static int lock_kernel_down(const char *where, enum lockdown_reason level)

Is the last parameter the reason or the level?  You're mixing the terms.

David
```