[PATCH] smack: remove redundant assignment to variable m

DORMANTno replies

From: Colin King <hidden>
Date: 2019-05-27 17:52:37
Also in: kernel-janitors, lkml
Subsystem: security subsystem, smack security module, the rest · Maintainers: Paul Moore, James Morris, "Serge E. Hallyn", Casey Schaufler, Linus Torvalds

From: Colin Ian King <redacted>

Variable m is assigned a value that is never read and m is later
reassigned in for-loop.  This the assignment is redundant and can
be mored.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 security/smack/smackfs.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 47f73a0dabb1..b66adafeb5fa 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -1174,7 +1174,6 @@ static ssize_t smk_write_net4addr(struct file *file, const char __user *buf,
 			rc = -EINVAL;
 			goto free_out;
 		}
-		m = BEBITS;
 		masks = 32;
 	}
 	if (masks > BEBITS) {
-- 
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help