[PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()

Subsystems: the rest, tpm device driver

STALE2778d

2 messages, 2 authors, 2019-02-20 · open the first message on its own page

[PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()

From: Yue Haibing <hidden>
Date: 2019-02-20 08:26:06

calc_tpm2_event_size() has an invalid signature because
it returns a 'size_t' where as its signature says that
it returns 'int'.

Cc: <redacted>
Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
Suggested-by: Jarkko Sakkinen <redacted>
Signed-off-by: Yue Haibing <redacted>
---
v3: fix My real name and cc stable
v2: modify patch title and commit message as Jarkko suggested
---
 drivers/char/tpm/eventlog/tpm2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/eventlog/tpm2.c b/drivers/char/tpm/eventlog/tpm2.c
index d8b7713..f824563 100644
--- a/drivers/char/tpm/eventlog/tpm2.c
+++ b/drivers/char/tpm/eventlog/tpm2.c
@@ -37,8 +37,8 @@
  *
  * Returns size of the event. If it is an invalid event, returns 0.
  */
-static int calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
-				struct tcg_pcr_event *event_header)
+static size_t calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
+				   struct tcg_pcr_event *event_header)
 {
 	struct tcg_efi_specid_event_head *efispecid;
 	struct tcg_event_field *event_field;
-- 
2.7.0

Re: [PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()

From: Jarkko Sakkinen <hidden>
Date: 2019-02-20 08:52:39

On Wed, Feb 20, 2019 at 04:25:38PM +0800, Yue Haibing wrote:
calc_tpm2_event_size() has an invalid signature because
it returns a 'size_t' where as its signature says that
it returns 'int'.

Cc: <redacted>
Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
Suggested-by: Jarkko Sakkinen <redacted>
Signed-off-by: Yue Haibing <redacted>
---
v3: fix My real name and cc stable
v2: modify patch title and commit message as Jarkko suggested
Thanks,

Reviewed-by: Jarkko Sakkinen <redacted>

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help