On 11/20/18 4:48 AM, Jarkko Sakkinen wrote:

quoted

+	/* Holds the resul of the last successful call to tpm_transmit() */

This comment is cruft.

Do you want me to remove it? This is the comment you proposed.

quoted

+	size_t response_length;

data_pending would be now perfectly fine name now that we concluded
that the original length is not needed to be stored. Better than this
as once you decrease it the variable name and contents mismatch.

Can we finally agree on something? We have changed three times already.
response_length is exactly what it is and data_pending is a bit vague.

quoted

+	/* Becomes true when the response (or part of it) is consumed */
+	bool response_read;

/* Tell whether response been consumed (read at least once). */

Ok I'll update the comment.

-- 
Tadeusz