Thread (32 messages) 32 messages, 2 authors, 2018-11-06

Re: [PATCH v3 01/16] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter

From: Jarkko Sakkinen <hidden>
Date: 2018-11-06 05:53:01
Also in: linux-integrity, lkml

On Mon, Nov 05, 2018 at 04:48:13PM -0500, Stefan Berger wrote:
quoted
  int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen)
  {
+	struct tpm_buf buf;
  	int rc;

  	chip = tpm_find_get_ops(chip);
  	if (!chip)
  		return -ENODEV;

-	rc = tpm_transmit_cmd(chip, NULL, cmd, buflen, 0, 0,
+	rc = tpm_buf_init(&buf, 0, 0);
+	if (rc)
+		goto out;
+
+	memcpy(buf.data, cmd, buflen);

Nit: buflen -> cmd_len
Agreed that it should but I try to keep the patch as minimal and
mechanical as I can.

Thank you.

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help