[PATCH] net/netlabel: Add list_next_rcu() in rcu_dereference().

Subsystems: networking [general], networking [labeled] (netlabel, labeled ipsec, secmark), the rest

STALE3217d

3 messages, 3 authors, 2017-11-18 · open the first message on its own page

[PATCH] net/netlabel: Add list_next_rcu() in rcu_dereference().

From: Tim Hansen <hidden>
Date: 2017-11-16 17:02:31

Add list_next_rcu() for fetching next list in rcu_deference safely.

Found with sparse in linux-next tree on tag next-20171116.

Signed-off-by: Tim Hansen <redacted>
---
 net/netlabel/netlabel_addrlist.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netlabel/netlabel_addrlist.h b/net/netlabel/netlabel_addrlist.h
index d0f38bc..ac709f0 100644
--- a/net/netlabel/netlabel_addrlist.h
+++ b/net/netlabel/netlabel_addrlist.h
@@ -87,7 +87,7 @@ static inline struct netlbl_af4list *__af4list_valid_rcu(struct list_head *s,
 	struct list_head *i = s;
 	struct netlbl_af4list *n = __af4list_entry(s);
 	while (i != h && !n->valid) {
-		i = rcu_dereference(i->next);
+		i = rcu_dereference(list_next_rcu(i));
 		n = __af4list_entry(i);
 	}
 	return n;
@@ -154,7 +154,7 @@ static inline struct netlbl_af6list *__af6list_valid_rcu(struct list_head *s,
 	struct list_head *i = s;
 	struct netlbl_af6list *n = __af6list_entry(s);
 	while (i != h && !n->valid) {
-		i = rcu_dereference(i->next);
+		i = rcu_dereference(list_next_rcu(i));
 		n = __af6list_entry(i);
 	}
 	return n;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/netlabel: Add list_next_rcu() in rcu_dereference().

From: David Miller <davem@davemloft.net>
Date: 2017-11-18 01:35:50

From: Tim Hansen <redacted>
Date: Thu, 16 Nov 2017 12:03:34 -0500
Add list_next_rcu() for fetching next list in rcu_deference safely.

Found with sparse in linux-next tree on tag next-20171116.

Signed-off-by: Tim Hansen <redacted>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/netlabel: Add list_next_rcu() in rcu_dereference().

From: Paul Moore <paul@paul-moore.com>
Date: 2017-11-18 13:28:06

On Fri, Nov 17, 2017 at 8:35 PM, David Miller [off-list ref] wrote:
From: Tim Hansen <redacted>
Date: Thu, 16 Nov 2017 12:03:34 -0500
quoted
Add list_next_rcu() for fetching next list in rcu_deference safely.

Found with sparse in linux-next tree on tag next-20171116.

Signed-off-by: Tim Hansen <redacted>
Applied.
Thanks guys.

My apologies I wasn't able to ACK the patch sooner, I was traveling
and had spotty network access.

-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help