[PATCH] security/keys: Adding newline after declaration

Subsystems: keys/keyrings, security subsystem, the rest

STALE3259d

2 messages, 2 authors, 2017-09-07 · open the first message on its own page

[PATCH] security/keys: Adding newline after declaration

From: Pushkar Jambhlekar <hidden>
Date: 2017-09-07 05:41:56

Fixing checkpatch warning to add newline after declaration

Signed-off-by: Pushkar Jambhlekar <redacted>
---
 security/keys/big_key.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/security/keys/big_key.c b/security/keys/big_key.c
index 835c1ab..bc4c6eb 100644
--- a/security/keys/big_key.c
+++ b/security/keys/big_key.c
@@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key)
 {
 	int ret = -EINVAL;
 	struct scatterlist sgio;
+
 	SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher);
 
 	if (crypto_skcipher_setkey(big_key_skcipher, key, ENC_KEY_SIZE)) {
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] security/keys: Adding newline after declaration

From: Joe Perches <joe@perches.com>
Date: 2017-09-07 05:55:02

On Thu, 2017-09-07 at 11:11 +0530, Pushkar Jambhlekar wrote:
Fixing checkpatch warning to add newline after declaration
[]
quoted hunk
diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
quoted hunk
@@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key)
 {
 	int ret = -EINVAL;
 	struct scatterlist sgio;
+
 	SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher);
checkpatch doesn't know that SKCIPHER_REQUEST_ON_STACK
is actually 2 declarations.

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help