# Re: \[PATCH 1/2\] block: remove unnecessary argument from blk\_execute\_rq\_nowait

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2021-01-21 17:12:28 
- List: linux-scsi
- Page: https://ratatoskr.run/linux-scsi/2021/01/6400366
- Thread: https://ratatoskr.run/linux-block/2021/01/6400364/t.md

```text
On Thu, Jan 21, 2021 at 03:29:04PM +0100, Guoqing Jiang wrote:
> The 'q' is not used since commit a1ce35fa4985 ("block: remove dead
> elevator code"), also update the comment of the function.

And more importantly it never really was needed to start with given
that we can triviall derive it from struct request.

> -extern void blk_execute_rq_nowait(struct request_queue *, struct gendisk *,
> +extern void blk_execute_rq_nowait(struct gendisk *,
>  				  struct request *, int, rq_end_io_fn *);
```
