[PATCH] iscsi: Fix some debug printf types

Subsystems: iscsi, scsi subsystem, the rest

STALE6454d

2 messages, 2 authors, 2009-02-08 · open the first message on its own page

[PATCH] iscsi: Fix some debug printf types

From: Boaz Harrosh <hidden>
Date: 2009-01-12 15:30:41

A couple of prints at lib/iscsi_tcp had the %Z missing from the
kprint format string. Just to show that debug_prints are not enabled
much.

Signed-off-by: Boaz Harrosh <redacted>
---
 drivers/scsi/iscsi_tcp.c    |    2 +-
 drivers/scsi/libiscsi_tcp.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 23808df..a566aa9 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -415,7 +415,7 @@ iscsi_sw_tcp_send_linear_data_prep(struct iscsi_conn *conn, void *data,
 	struct hash_desc *tx_hash = NULL;
 	unsigned int hdr_spec_len;
 
-	debug_tcp("%s(%p, datalen=%d%s)\n", __func__, tcp_conn, len,
+	debug_tcp("%s(%p, datalen=%Zd%s)\n", __func__, tcp_conn, len,
 		  conn->datadgst_en? ", digest enabled" : "");
 
 	/* Make sure the datalen matches what the caller
diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
index a745f91..12354c5 100644
--- a/drivers/scsi/libiscsi_tcp.c
+++ b/drivers/scsi/libiscsi_tcp.c
@@ -356,7 +356,7 @@ iscsi_segment_seek_sg(struct iscsi_segment *segment,
 	struct scatterlist *sg;
 	unsigned int i;
 
-	debug_scsi("iscsi_segment_seek_sg offset %u size %llu\n",
+	debug_scsi("iscsi_segment_seek_sg offset %u size %Zu\n",
 		  offset, size);
 	__iscsi_segment_init(segment, size, done, hash);
 	for_each_sg(sg_list, sg, sg_count, i) {
-- 
1.6.0.1

Re: [PATCH] iscsi: Fix some debug printf types

From: Mike Christie <hidden>
Date: 2009-02-08 19:08:41

Boaz Harrosh wrote:
quoted hunk
A couple of prints at lib/iscsi_tcp had the %Z missing from the
kprint format string. Just to show that debug_prints are not enabled
much.

Signed-off-by: Boaz Harrosh <redacted>
---
 drivers/scsi/iscsi_tcp.c    |    2 +-
 drivers/scsi/libiscsi_tcp.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 23808df..a566aa9 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -415,7 +415,7 @@ iscsi_sw_tcp_send_linear_data_prep(struct iscsi_conn *conn, void *data,
 	struct hash_desc *tx_hash = NULL;
 	unsigned int hdr_spec_len;
 
-	debug_tcp("%s(%p, datalen=%d%s)\n", __func__, tcp_conn, len,
+	debug_tcp("%s(%p, datalen=%Zd%s)\n", __func__, tcp_conn, len,
 		  conn->datadgst_en? ", digest enabled" : "");
 

I got these fixed when I did the modparam debug patch.

I used a lower case z (%zd) though. I thought I saw that in a review comment from Andrew Morton or in a kernel janitor patch, so I thought that was the preferred way to do it in kernel code, but was not 100% sure. Let me know if I goofed and I will fix it.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help