# Re: \[PATCH v2 3/3\] mm/gup: Remove try\_get\_page(), call try\_get\_compound\_head() directly

- From: William Kucharski \<hidden\>
- Date: 2021-08-12 02:17:49 
- List: linux-s390
- Page: https://ratatoskr.run/linux-s390/2021/08/212161
- Thread: https://ratatoskr.run/linux-mm/2021/08/212074/t.md

```text


> On Aug 11, 2021, at 4:07 PM, John Hubbard [ref] wrote:
> 
> On 8/11/21 1:35 PM, William Kucharski wrote:
>> I agree that try_get_page() should probably be removed entirely; is there
>> a reason you didn't in v2 of the patch?
> 
> Hi William,
> 
> This patch *does* remove try_get_page() entirely! Look below. I'll reply
> inline, below, to show where that happens.

Ah, my bad.  I was conflating it with try_grab_page() in patch 2/3, which
also seems like it should be an inline, but given your explanation re:
try_get_compound_head() it makes perfect sense.
 
For the series:

Reviewed-by: William Kucharski <redacted>

```
