# \[PATCH\] rtc: tps6586x: move to use request\_irq by IRQF\_NO\_AUTOEN flag

- Subsystems: REAL TIME CLOCK (RTC) SUBSYSTEM, THE REST
- Maintainers: Alexandre Belloni, Linus Torvalds
- List: linux-rtc
- 1 message, 1 author
- Page: https://ratatoskr.run/linux-rtc/2021/03/9567136/t

## \[PATCH\] rtc: tps6586x: move to use request\_irq by IRQF\_NO\_AUTOEN flag

- From: Tian Tao \<tiantao6@hisilicon.com\>
- Date: 2021-03-13 06:36:46 
- Message: https://ratatoskr.run/linux-rtc/2021/03/9567136.md

```text
request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable
because of requesting.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/rtc/rtc-tps6586x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c
index a980337..85203a7 100644
--- a/drivers/rtc/rtc-tps6586x.c
+++ b/drivers/rtc/rtc-tps6586x.c
@@ -268,11 +268,9 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
 	rtc->rtc->start_secs = mktime64(2009, 1, 1, 0, 0, 0);
 	rtc->rtc->set_start_time = true;
 
-	irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);
-
 	ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
 				tps6586x_rtc_irq,
-				IRQF_ONESHOT,
+				IRQF_ONESHOT | IRQ_NOAUTOEN,
 				dev_name(&pdev->dev), rtc);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "request IRQ(%d) failed with ret %d\n",
-- 
2.7.4

```
