Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes

On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger [off-list ref] wrote:

On 29/01/2021 10:49, Hsin-Hsiung Wang wrote:

quoted

+             mt6359codec: mt6359codec {
+             };

I understand that the dmic-mode and mic-type-X depends on the actual board on
which it is used. In that case I think we should add mt6359codec node in the dts
instead of dtsi file. I'd advise to set these properties as well as otherwise we
get a (slightly misleading) warning in the driver.

I feel it is better to include the node in dtsi to represent the whole
MT6359 PMIC.

We could either:
- Set default values of these properties in the dtsi to avoid the
warning message.
- Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/

On 02/02/2021 04:51, Tzung-Bi Shih wrote:

On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger [off-list ref] wrote:

quoted

On 29/01/2021 10:49, Hsin-Hsiung Wang wrote:

quoted

+             mt6359codec: mt6359codec {
+             };

I understand that the dmic-mode and mic-type-X depends on the actual board on
which it is used. In that case I think we should add mt6359codec node in the dts
instead of dtsi file. I'd advise to set these properties as well as otherwise we
get a (slightly misleading) warning in the driver.

I feel it is better to include the node in dtsi to represent the whole
MT6359 PMIC.

We could either:
- Set default values of these properties in the dtsi to avoid the
warning message.
- Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/

As this got accpeted upstream, you don't need to do anything about it.

Thanks for the pointer.
Matthias