# Re: \[PATCH v3 4/5\] amba: Make the remove callback return void

- From: Suzuki K Poulose \<suzuki.poulose@arm.com\>
- Date: 2021-01-27 00:28:09 
- List: linux-rtc
- Page: https://ratatoskr.run/linux-rtc/2021/01/6248541
- Thread: https://ratatoskr.run/linux-crypto/2021/01/6248565/t.md

```text
Hi

On 1/26/21 4:58 PM, Uwe Kleine-König wrote:
> All amba drivers return 0 in their remove callback. Together with the
> driver core ignoring the return value anyhow, it doesn't make sense to
> return a value here.
>
> Change the remove prototype to return void, which makes it explicit that
> returning an error value doesn't work as expected. This simplifies changing
> the core remove callback to return void, too.
>
> Reviewed-by: Ulf Hansson <redacted>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory
> Acked-by: Mark Brown <broonie@kernel.org>
 > Acked-by: Dmitry Torokhov [ref]
> Acked-by: Linus Walleij <redacted>
> Signed-off-by: Uwe Kleine-König <redacted>


>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---

You are most likely to have a conflict for the above file, with what is
in coresight/next. It should be easy to resolve.

Otherwise, the changes look good for the drivers/hwtracing/coresight/*

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
```