# \[rtc-linux\] Re: \[PATCH v2 03/10\] mfd: ac100: Add driver for X-Powers AC100 audio codec / RTC combo IC

- From: Lee Jones \<hidden\>
- Date: 2016-06-15 12:36:09 
- List: linux-rtc
- Page: https://ratatoskr.run/linux-rtc/2016/06/4774124
- Thread: https://ratatoskr.run/linux-devicetree/2016/06/4774037/t.md

```text
On Wed, 15 Jun 2016, Chen-Yu Tsai wrote:

> The AC100 is a multifunction device with an audio codec subsystem and
> an RTC subsystem. These two subsystems share a common register space
> and host interface.
>=20
> Signed-off-by: Chen-Yu Tsai <redacted>
> ---

Change log?

>  drivers/mfd/Kconfig       |  10 +++
>  drivers/mfd/Makefile      |   2 +
>  drivers/mfd/ac100.c       | 135 +++++++++++++++++++++++++++++++++++
>  include/linux/mfd/ac100.h | 176 ++++++++++++++++++++++++++++++++++++++++=
++++++
>  4 files changed, 323 insertions(+)
>  create mode 100644 drivers/mfd/ac100.c
>  create mode 100644 include/linux/mfd/ac100.h
>=20
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1bcf601de5bc..bd83849a0c8d 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -101,6 +101,16 @@ config MFD_BCM590XX
>  	help
>  	  Support for the BCM590xx PMUs from Broadcom
> =20
> +config MFD_AC100
> +	tristate "X-Powers AC100"
> +	select MFD_CORE
> +	depends on SUNXI_RSB
> +	help
> +	  If you say Y here you get support for the X-Powers AC100 audio codec
> +	  IC.
> +	  This driver include only the core APIs. You have to select individual
> +	  components like codecs or RTC under the corresponding menus.
> +
>  config MFD_AXP20X
>  	tristate
>  	select MFD_CORE
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 42a66e19e191..60f9a6b0557c 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -113,6 +113,8 @@ obj-$(CONFIG_PMIC_DA9052)	+=3D da9052-irq.o
>  obj-$(CONFIG_PMIC_DA9052)	+=3D da9052-core.o
>  obj-$(CONFIG_MFD_DA9052_SPI)	+=3D da9052-spi.o
>  obj-$(CONFIG_MFD_DA9052_I2C)	+=3D da9052-i2c.o
> +
> +obj-$(CONFIG_MFD_AC100)		+=3D ac100.o
>  obj-$(CONFIG_MFD_AXP20X)	+=3D axp20x.o
>  obj-$(CONFIG_MFD_AXP20X_I2C)	+=3D axp20x-i2c.o
>  obj-$(CONFIG_MFD_AXP20X_RSB)	+=3D axp20x-rsb.o
> diff --git a/drivers/mfd/ac100.c b/drivers/mfd/ac100.c
> new file mode 100644
> index 000000000000..15d24fa77771
> --- /dev/null
> +++ b/drivers/mfd/ac100.c
> @@ -0,0 +1,135 @@
> +/*
> + * ac100.c - MFD core driver for X-Powers' AC100 Audio Codec IC

Nit: Drop the filename here.

Apart from that:
  Acked-by: Lee Jones [ref]

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
```
