# Re: \[PATCH V4 04/19\] trace/osnoise: Support a list of trace\_array \*tr

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2021-10-25 13:35:47 
- List: linux-rt-users
- Page: https://ratatoskr.run/linux-rt-users/2021/10/1552541
- Thread: https://ratatoskr.run/linux-rt-users/2021/10/1549551/t.md

```text
On Mon, 25 Oct 2021 11:10:26 +0200
Daniel Bristot de Oliveira [ref] wrote:

> The start/stop/reset operations are called from trace "core" operations. So they
> are all protected/serialized by trace_types_lock (by trace/core).
> 
> So, it seems that the way to go is to remove the rcu_read_lock/unlock() from
> unregister, adding a lockdep check to see if trace_types_lock is help as a bonus?

Yes, I would recommend the lockdep assert added. This way it also documents
what lock protects modification of the list.

Thanks,

-- Steve

```
