# \[PATCH RT 1/2\] locking/rwsem-rt: Remove might\_sleep() in \_\_up\_read()

- From: zanussi@kernel.org
- Date: 2021-09-02 20:26:38 
- List: linux-rt-users
- Page: https://ratatoskr.run/linux-rt-users/2021/09/1496161
- Thread: https://ratatoskr.run/linux-rt-users/2021/09/1496160/t.md

```text
From: Andrew Halaney <redacted>

v5.4.143-rt64-rc1 stable review patch.
If anyone has any objections, please let me know.

-----------


[ Upstream commit b2ed0a4302faf2bb09e97529dd274233c082689b ]

There's no chance of sleeping here, the reader is giving up the
lock and possibly waking up the writer who is waiting on it.

Reported-by: Chunyu Hu <redacted>
Signed-off-by: Andrew Halaney <redacted>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
 kernel/locking/rwsem-rt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/locking/rwsem-rt.c b/kernel/locking/rwsem-rt.c
index 19ea20be3fd7..966946454ced 100644
--- a/kernel/locking/rwsem-rt.c
+++ b/kernel/locking/rwsem-rt.c
@@ -200,7 +200,6 @@ void __up_read(struct rw_semaphore *sem)
 	if (!atomic_dec_and_test(&sem->readers))
 		return;
 
-	might_sleep();
 	raw_spin_lock_irq(&m->wait_lock);
 	/*
 	 * Wake the writer, i.e. the rtmutex owner. It might release the
-- 
2.17.1

```
