# Re: \[PATCH RT 2/6\] tcp: Remove superfluous BH-disable around listening\_hash

- From: Sebastian Andrzej Siewior \<bigeasy@linutronix.de\>
- Date: 2020-11-09 17:36:03 
- List: linux-rt-users
- Page: https://ratatoskr.run/linux-rt-users/2020/11/6169833
- Thread: https://ratatoskr.run/linux-rt-users/2020/11/6167721/t.md

```text
On 2020-11-09 12:01:06 [-0500], Steven Rostedt wrote:
> Note, I took this because it mentioned:
> 
> "Commit
>        9652dc2eb9e40 ("tcp: relax listening_hash operations")
>     
>     removed the need to disable bottom half while acquiring
>     listening_hash.lock. There are still two callers left which disable
>     bottom half before the lock is acquired."
> 
> And that commit was added in 4.10.

Yes. I was aiming to sell this as an optimisation to upstream but that
patch isn't exactly a beauty queen and that optimisation isn't enormous
so they may not want to buy it.
Also: upstream's lockdep isn't complaining here so the alternative route
is to get RT's lockdep to be quiet here as well and then drop that
patch.

Sebastian
```
