Thread (5 messages) 5 messages, 2 authors, 2019-08-13

Re: Boot issue on odroid-XU4

From: Benjamin Rouxel <hidden>
Date: 2019-08-13 10:02:00

Hi Sebastian,

I rolled back my changes and removed IRQF_ONESHOT as you said and it is
indeed working, no more hanging out at boot.

drivers/i2c/busses/i2c-exynos5.c

760     ret = devm_request_irq(&pdev->dev, i2c->irq, exynos5_i2c_irq,
761                 IRQF_NO_SUSPEND,
762                 dev_name(&pdev->dev), i2c);

Should we keep that fix?

Best,

Benjamin.


Le 13/08/2019 à 11:00, Sebastian Andrzej Siewior a écrit :
On 2019-07-24 19:07:46 [+0200], Benjamin Rouxel wrote:
quoted
Hi,

I thought it would be harder to debug/fix. Please find attached a patch
that corrects this boot issue, the exynos5 i2c driver was still using
the "spinlock_t" structure and all initial utility functions, I just
changed it to use the "raw_spinlock_t" struct.

Was it the good fix?
Could you remove the IRQF_ONESHOT from the devm_request_irq() statement
and check if this fixes the issue? I don't see the reason for it.
quoted
Best,

Benjamin Rouxel.
Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help