# \[PATCH 08/15\] seqlock: provide the same ordering semantics as mainline

- From: Tom Zanussi \<zanussi@kernel.org\>
- Date: 2018-08-14 21:43:31 
- List: linux-rt-users
- Page: https://ratatoskr.run/linux-rt-users/2018/08/16487180
- Thread: https://ratatoskr.run/linux-rt-users/2018/08/16487170/t.md

```text
v3.18.117-rt105 rt-stable review patch.  If anyone has any objections,
please let me know.

------------------

From: Julia Cartwright <redacted>

[ Upstream rt-devel commit afa4c06b89a3c0fb7784ff900ccd707bef519cb7 ]

The mainline implementation of read_seqbegin() orders prior loads w.r.t.
the read-side critical section.  Fixup the RT writer-boosting
implementation to provide the same guarantee.

Also, while we're here, update the usage of ACCESS_ONCE() to use
READ_ONCE().

Fixes: e69f15cf77c23 ("seqlock: Prevent rt starvation")
Cc: <redacted>
Signed-off-by: Julia Cartwright <redacted>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Tom Zanussi <redacted>
---
 include/linux/seqlock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 4acd0e2fb5cb..efa234031230 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -338,6 +338,7 @@ repeat:
 		spin_unlock_wait(&sl->lock);
 		goto repeat;
 	}
+	smp_rmb();
 	return ret;
 }
 #endif
-- 
2.14.1
```
