# Re: \[PATCH 09/15\] squashfs: make use of local lock in multi\_cpu decompressor

- From: Julia Cartwright \<hidden\>
- Date: 2018-08-14 23:25:41 
- List: linux-rt-users
- Page: https://ratatoskr.run/linux-rt-users/2018/08/16487178
- Thread: https://ratatoskr.run/linux-rt-users/2018/08/16487170/t.md

```text
Hey Tom-

On Tue, Aug 14, 2018 at 01:54:02PM -0500, Tom Zanussi wrote:
> v3.18.117-rt105 rt-stable review patch.  If anyone has any objections,
> please let me know.
> 
> ------------------
> 
> From: Julia Cartwright <redacted>
> 
> [ Upstream rt-devel commit c160736542d7b3d67da32848d2f028b8e35730e5 ]
> 
> Currently, the squashfs multi_cpu decompressor makes use of
> get_cpu_ptr()/put_cpu_ptr(), which unconditionally disable preemption
> during decompression.
> 
> Because the workload is distributed across CPUs, all CPUs can observe a
> very high wakeup latency, which has been seen to be as much as 8000us.
> 
> Convert this decompressor to make use of a local lock, which will allow
> execution of the decompressor with preemption-enabled, but also ensure
> concurrent accesses to the percpu compressor data on the local CPU will
> be serialized.
> 
> Cc: <redacted>
> Reported-by: Alexander Stein <redacted>
> Tested-by: Alexander Stein <redacted>
> Signed-off-by: Julia Cartwright <redacted>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Tom Zanussi <redacted>
> ---
[..]
>  void *squashfs_decompressor_create(struct squashfs_sb_info *msblk,
>  						void *comp_opts)
>  {
> @@ -79,10 +82,15 @@ int squashfs_decompress(struct squashfs_sb_info *msblk, struct buffer_head **bh,
>  {
>  	struct squashfs_stream __percpu *percpu =
>  			(struct squashfs_stream __percpu *) msblk->stream;
> -	struct squashfs_stream *stream = get_cpu_ptr(percpu);
> -	int res = msblk->decompressor->decompress(msblk, stream->stream, bh, b,
> -		offset, length, output);
> -	put_cpu_ptr(stream);
> +	struct squashfs_stream *stream;
> +	int res;
> +
> +	stream = get_locked_ptr(stream_lock, percpu);

This patch depends on the introduction of the {get,put}_locked_ptr()
per-cpu access variants.  So, you'll want to also pull commit

 3d45cf23db4f76cd3 ("locallock: provide {get,put}_locked_ptr() variants")

>From rt-devel as well.

  Julia
```
