# \[PATCH RT 08/12\] net: Make synchronize\_rcu\_expedited() conditional on !RT\_FULL

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2016-02-26 21:42:17 
- List: linux-rt-users
- Page: https://ratatoskr.run/linux-rt-users/2016/02/4695870
- Thread: https://ratatoskr.run/linux-rt-users/2016/02/4695868/t.md

```text
3.18.27-rt26-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Josh Cartwright <redacted>

While the use of synchronize_rcu_expedited() might make
synchronize_net() "faster", it does so at significant cost on RT
systems, as expediting a grace period forcibly preempts any
high-priority RT tasks (via the stop_machine() mechanism).

Without this change, we can observe a latency spike up to 30us with
cyclictest by rapidly unplugging/reestablishing an ethernet link.

Suggested-by: Paul E. McKenney <redacted>
Signed-off-by: Josh Cartwright <redacted>
Cc: bigeasy@linutronix.de
Acked-by: Eric Dumazet <redacted>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Paul E. McKenney <redacted>
Link: http://lkml.kernel.org/r/20151027123153.GG8245@jcartwri.amer.corp.natinst.com
Signed-off-by: Thomas Gleixner <redacted>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 1cbcf08cc224..48872718d8e2 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6813,7 +6813,7 @@ EXPORT_SYMBOL(free_netdev);
 void synchronize_net(void)
 {
 	might_sleep();
-	if (rtnl_is_locked())
+	if (rtnl_is_locked() && !IS_ENABLED(CONFIG_PREEMPT_RT_FULL))
 		synchronize_rcu_expedited();
 	else
 		synchronize_rcu();
-- 
2.7.0
```
