Thread (3 messages) 3 messages, 3 authors, 2013-08-28

Re: 3.10.4-rt1 : too many arguments to function 'phy_connect'

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2013-08-12 11:13:30

* Paul Chavent | 2013-08-12 09:31:55 [+0200]:
Hi.
Hi Paul,
When i compile this version (3.10.4-rt1) for typical da850 (arm omap)
config i get this error :

 CC      drivers/net/ethernet/ti/davinci_emac.o
drivers/net/ethernet/ti/davinci_emac.c: In function 'emac_dev_open':
drivers/net/ethernet/ti/davinci_emac.c:1604:9: error: too many
arguments to function 'phy_connect'
        PHY_INTERFACE_MODE_MII);
        ^
In file included from drivers/net/ethernet/ti/davinci_emac.c:56:0:
include/linux/phy.h:522:21: note: declared here
struct phy_device * phy_connect(struct net_device *dev, const char
*bus_id,
                    ^

There are some suspect lines in the patch that add an extra argument
to the phy_connect function without modifying its signature.

The compilation complete if i remove this extra arg (but the kernel
don't start, i will check my config for this point).
The series files has a bunch of cpsw patches. For the next -rt release
I'm going to remove all of them as they were only required for the v3.8
release were I backported the cpsw driver. If you drop them, cpsw will
compile. After quick testing I've seen that the cpsw wasn't running nice
but did not crash / hang the system. That is something that should be
investigated.
Regards.

Paul.
Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help