[PATCH RFC] rt-tests: Makefile get machinetype from compiler instead of uname

STALE5242d

3 messages, 2 authors, 2012-05-02 · open the first message on its own page

[PATCH RFC] rt-tests: Makefile get machinetype from compiler instead of uname

From: Frank Rowand <hidden>
Date: 2012-05-02 02:34:36

Fix the machinetype check for cross-compiling.

This has been tested on an x86_64  Fedora host for an x86_64 target and
an ARM target.  Additional testing would be greatly appreciated.

Signed-off-by: Frank Rowand <redacted>
---
 Makefile |    4 	2 +	2 -	0 !
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/Makefile
===================================================================
--- a/Makefile
+++ b/Makefile
@@ -14,8 +14,8 @@ bindir  ?= $(prefix)/bin
 mandir	?= $(prefix)/share/man
 srcdir	?= $(prefix)/src
 
-machinetype = $(shell uname -m | \
-    sed -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/')
+machinetype = $(shell $(CC) -dumpmachine | \
+    sed -e 's/-.*//' -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/')
 ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),)
 NUMA 	:= 1
 endif

Re: [PATCH RFC] rt-tests: Makefile get machinetype from compiler instead of uname

From: Darren Hart <hidden>
Date: 2012-05-02 20:31:03

On 05/01/2012 07:34 PM, Frank Rowand wrote:
Fix the machinetype check for cross-compiling.

This has been tested on an x86_64  Fedora host for an x86_64 target and
an ARM target.  Additional testing would be greatly appreciated.

Built in Yocto using an ARM cross compiler and ran cyclictest in qemuarm
with the resulting image. Appears sane.

What problem manifested before?
Signed-off-by: Frank Rowand <redacted>
Tested-by: Darren Hart <redacted>
quoted hunk
---
 Makefile |    4 	2 +	2 -	0 !
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/Makefile
===================================================================
--- a/Makefile
+++ b/Makefile
@@ -14,8 +14,8 @@ bindir  ?= $(prefix)/bin
 mandir	?= $(prefix)/share/man
 srcdir	?= $(prefix)/src
 
-machinetype = $(shell uname -m | \
-    sed -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/')
+machinetype = $(shell $(CC) -dumpmachine | \
+    sed -e 's/-.*//' -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/')
 ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),)
 NUMA 	:= 1
 endif
-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH RFC] rt-tests: Makefile get machinetype from compiler instead of uname

From: Frank Rowand <hidden>
Date: 2012-05-02 21:02:12

On 05/02/12 13:30, Darren Hart wrote:
On 05/01/2012 07:34 PM, Frank Rowand wrote:
quoted
Fix the machinetype check for cross-compiling.

This has been tested on an x86_64  Fedora host for an x86_64 target and
an ARM target.  Additional testing would be greatly appreciated.

Built in Yocto using an ARM cross compiler and ran cyclictest in qemuarm
with the resulting image. Appears sane.

What problem manifested before?
quoted
Signed-off-by: Frank Rowand <redacted>
Tested-by: Darren Hart <redacted>
Thanks!

As you and jkacur surmised, the problem I'm trying to fix is that
the machinetype got the host machine type instead of the target
machine type.  Could definitely word the description better...

-Frank
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help