Thread (19 messages) 19 messages, 9 authors, 2008-07-06

Re: [PATCH][resubmit] x86: enable preemption in delay

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2008-06-18 16:16:34
Also in: lkml


On Wed, 18 Jun 2008, Nick Piggin wrote:
There are _some_ cases where it can be used, but nobody has been
able to come up with compelling uses really. I don't think this
case is helped very much either because the logic in there using
preempt-disable is fine, isn't it?

Except that it should also have a cond_resched in it. Seems like
an ideal place to put cond_resched because it is not a fastpath.
Does it really need a cond_resched? preempt_enable when it goes to zero
will already check to see if it should schedule.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help