# Re: \[PATCH v2 56/63\] RDMA/mlx5: Use struct\_group() to zero struct mlx5\_ib\_mr

- From: Jason Gunthorpe \<jgg@ziepe.ca\>
- Date: 2021-08-20 12:34:09 
- List: linux-rdma
- Page: https://ratatoskr.run/linux-rdma/2021/08/1483924
- Thread: https://ratatoskr.run/linux-rdma/2021/08/1481241/t.md

```text
On Thu, Aug 19, 2021 at 11:14:37AM -0700, Kees Cook wrote:

> Which do you mean? When doing the conversions I tended to opt for
> struct_group() since it provides more robust "intentionality". Strictly
> speaking, the new memset helpers are doing field-spanning writes, but the
> "clear to the end" pattern was so common it made sense to add the helpers,
> as they're a bit less disruptive. It's totally up to you! :)

Well, of the patches you cc'd to me only this one used the struct
group..

Jason 
```