On 01 Sep 2011, 00:46 Steve Wise wrote:

On 08/31/2011 03:43 PM, Alexey Khoroshilov wrote:

quoted

The patch "RDMA/cxgb4: EEH errors can hang the driver" removes
mutex lock/unlock from c4iw_alloc() except for error path.
This patch removes the remained mutex_unlock(&dev_mutex).

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov<redacted>
---
  drivers/infiniband/hw/cxgb4/device.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/device.c

b/drivers/infiniband/hw/cxgb4/device.c
index 40a13cc..35896ff 100644

--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c

@@ -414,7 +414,6 @@ static struct c4iw_dev *c4iw_alloc(const struct

cxgb4_lld_info *infop)

  	ret = c4iw_rdev_open(&devp->rdev);
  	if (ret) {
-		mutex_unlock(&dev_mutex);
  		printk(KERN_ERR MOD "Unable to open CXIO rdev err %d\n", ret);
  		ib_dealloc_device(&devp->ibdev);
  		return ERR_PTR(ret);

This is actually included in my previously submitted patch:

https://patchwork.kernel.org/patch/1026942/

Steve.

Great.

--
Alexey