[PATCH] md/raid1: drop the redundant sysfs_unlink_rdev()

From
<hidden>
Date
2026-11-01 12:10:02
Also in
lkml
raid1_reshape() unlinks the old "rd{d}" link, assigns the new
raid_disk, then unlinks again.  The second call targets "rd{d2}", a slot
that has no sysfs link yet, so it is a no-op; sysfs_link_rdev() below
creates it.

Signed-off-by: Shao Mingyin <redacted>
---
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 894efb50c6d5..25b80ad52f00 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -3351,7 +3351,6 @@ static int raid1_reshape(struct mddev *mddev)
 		if (rdev && rdev->raid_disk != d2) {
 			sysfs_unlink_rdev(mddev, rdev);
 			rdev->raid_disk = d2;
-			sysfs_unlink_rdev(mddev, rdev);
 			if (sysfs_link_rdev(mddev, rdev))
 				pr_warn("md/raid1:%s: cannot register rd%d\n",
 					mdname(mddev), rdev->raid_disk);
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help