# Re: fix a lock order reversal in md\_alloc

- From: Song Liu \<song@kernel.org\>
- Date: 2021-09-02 05:06:54 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2021/09/6640647
- Thread: https://ratatoskr.run/linux-raid/2021/09/6640639/t.md

```text
Hi Christoph,

On Wed, Sep 1, 2021 at 4:39 AM Christoph Hellwig [ref] wrote:
>
> Hi Song,
>
> the first patch in this series fixed the reported lock order reversal
> in md_alloc.  The rest sort out the error handling in that function,
> starting with the patch from Luis to handle add_disk errors, which
> would otherwise conflict with the first patch.

Thanks for the fixes! I have noticed the issue, but haven't got a good
solution for it. I will test and apply the set (maybe after the labor day
long weekend).

>
> Note that I have had a hard time verifying this all works fine as the
> testsuite in mdadm already keeps failing a lot for me with the baseline
> kernel. Some of thos reproducibly and others randomly.  Is there a
> good document somehow describing what to expect from the mdadm test
> suite?

Unfortunately, mdadm test needs quite some work to be really useful again.
I will work with Jes and other folks to come up with a plan for this.

Thanks again,
Song
```