[PATCH] md: allow to set the fail_fast on RAID1/RAID10

Subsystems: software raid (multiple disks) support, the rest

STALE1782d

6 messages, 2 authors, 2021-10-08 · open the first message on its own page

[PATCH] md: allow to set the fail_fast on RAID1/RAID10

From: Li Feng <hidden>
Date: 2021-09-13 03:22:08 

When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.

Export the fail_fast flag to the userspace to support the read and
write.

Signed-off-by: Li Feng <redacted>
---
 drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
 static struct rdev_sysfs_entry rdev_ppl_size =
 __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
 
+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+	return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+	int ret;
+	bool bit;
+
+	ret = kstrtobool(buf, &bit);
+	if (ret)
+		return ret;
+
+	if (test_bit(FailFast, &rdev->flags) && !bit) {
+		clear_bit(FailFast, &rdev->flags);
+		md_update_sb(rdev->mddev, 1);
+	} else if (!test_bit(FailFast, &rdev->flags) && bit) {
+		set_bit(FailFast, &rdev->flags);
+		md_update_sb(rdev->mddev, 1);
+	}
+	return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
 static struct attribute *rdev_default_attrs[] = {
 	&rdev_state.attr,
 	&rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
 	&rdev_unack_bad_blocks.attr,
 	&rdev_ppl_sector.attr,
 	&rdev_ppl_size.attr,
+	&rdev_fail_fast.attr,
 	NULL,
 };
 static ssize_t
-- 
2.31.1

Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10

From: Li Feng <hidden>
Date: 2021-09-15 15:09:07 

ping ...

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月13日周一 上午11:22写道：
quoted hunk
When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.

Export the fail_fast flag to the userspace to support the read and
write.

Signed-off-by: Li Feng <redacted>
---
 drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
 static struct rdev_sysfs_entry rdev_ppl_size =
 __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);

+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+       return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+       int ret;
+       bool bit;
+
+       ret = kstrtobool(buf, &bit);
+       if (ret)
+               return ret;
+
+       if (test_bit(FailFast, &rdev->flags) && !bit) {
+               clear_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       } else if (!test_bit(FailFast, &rdev->flags) && bit) {
+               set_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       }
+       return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
 static struct attribute *rdev_default_attrs[] = {
        &rdev_state.attr,
        &rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
        &rdev_unack_bad_blocks.attr,
        &rdev_ppl_sector.attr,
        &rdev_ppl_size.attr,
+       &rdev_fail_fast.attr,
        NULL,
 };
 static ssize_t
--
2.31.1

Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10

From: Li Feng <hidden>
Date: 2021-09-27 13:24:44 

Hi Song,

What about this feature?

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月15日周三 下午11:08写道：
ping ...

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月13日周一 上午11:22写道：
quoted
When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.

Export the fail_fast flag to the userspace to support the read and
write.

Signed-off-by: Li Feng <redacted>
---
 drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
 static struct rdev_sysfs_entry rdev_ppl_size =
 __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);

+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+       return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+       int ret;
+       bool bit;
+
+       ret = kstrtobool(buf, &bit);
+       if (ret)
+               return ret;
+
+       if (test_bit(FailFast, &rdev->flags) && !bit) {
+               clear_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       } else if (!test_bit(FailFast, &rdev->flags) && bit) {
+               set_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       }
+       return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
 static struct attribute *rdev_default_attrs[] = {
        &rdev_state.attr,
        &rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
        &rdev_unack_bad_blocks.attr,
        &rdev_ppl_sector.attr,
        &rdev_ppl_size.attr,
+       &rdev_fail_fast.attr,
        NULL,
 };
 static ssize_t
--
2.31.1

Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10

From: Li Feng <hidden>
Date: 2021-10-07 07:00:36 

Continue ping...

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月27日周一 下午9:24写道：
Hi Song,

What about this feature?

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月15日周三 下午11:08写道：
quoted
ping ...

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月13日周一 上午11:22写道：
quoted
When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.

Export the fail_fast flag to the userspace to support the read and
write.

Signed-off-by: Li Feng <redacted>
---
 drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
 static struct rdev_sysfs_entry rdev_ppl_size =
 __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);

+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+       return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+       int ret;
+       bool bit;
+
+       ret = kstrtobool(buf, &bit);
+       if (ret)
+               return ret;
+
+       if (test_bit(FailFast, &rdev->flags) && !bit) {
+               clear_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       } else if (!test_bit(FailFast, &rdev->flags) && bit) {
+               set_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       }
+       return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
 static struct attribute *rdev_default_attrs[] = {
        &rdev_state.attr,
        &rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
        &rdev_unack_bad_blocks.attr,
        &rdev_ppl_sector.attr,
        &rdev_ppl_size.attr,
+       &rdev_fail_fast.attr,
        NULL,
 };
 static ssize_t
--
2.31.1

Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10

From: Song Liu <song@kernel.org>
Date: 2021-10-07 14:59:14 

On Thu, Oct 7, 2021 at 12:00 AM Li Feng [off-list ref] wrote:
Continue ping...

Thanks,
Feng Li
Hmm.. this is weird. I didn't see previous emails in this thread.
Could you please
send it again?

Thanks,
Song

Li Feng [off-list ref] 于2021年9月27日周一 下午9:24写道：
quoted
Hi Song,

What about this feature?

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月15日周三 下午11:08写道：
quoted
ping ...

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月13日周一 上午11:22写道：
quoted
When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.

Export the fail_fast flag to the userspace to support the read and
write.

Signed-off-by: Li Feng <redacted>
---
 drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
 static struct rdev_sysfs_entry rdev_ppl_size =
 __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);

+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+       return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+       int ret;
+       bool bit;
+
+       ret = kstrtobool(buf, &bit);
+       if (ret)
+               return ret;
+
+       if (test_bit(FailFast, &rdev->flags) && !bit) {
+               clear_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       } else if (!test_bit(FailFast, &rdev->flags) && bit) {
+               set_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       }
+       return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
 static struct attribute *rdev_default_attrs[] = {
        &rdev_state.attr,
        &rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
        &rdev_unack_bad_blocks.attr,
        &rdev_ppl_sector.attr,
        &rdev_ppl_size.attr,
+       &rdev_fail_fast.attr,
        NULL,
 };
 static ssize_t
--
2.31.1

Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10

From: Li Feng <hidden>
Date: 2021-10-08 03:23:42 

Done, thanks for responding.

Thanks,
Feng Li

Song Liu [off-list ref] 于2021年10月7日周四 下午10:59写道：
On Thu, Oct 7, 2021 at 12:00 AM Li Feng [off-list ref] wrote:
quoted
Continue ping...

Thanks,
Feng Li
Hmm.. this is weird. I didn't see previous emails in this thread.
Could you please
send it again?

Thanks,
Song
quoted
Li Feng [off-list ref] 于2021年9月27日周一 下午9:24写道：
quoted
Hi Song,

What about this feature?

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月15日周三 下午11:08写道：
quoted
ping ...

Thanks,
Feng Li

Li Feng [off-list ref] 于2021年9月13日周一 上午11:22写道：
quoted
When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.

Export the fail_fast flag to the userspace to support the read and
write.

Signed-off-by: Li Feng <redacted>
---
 drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
 static struct rdev_sysfs_entry rdev_ppl_size =
 __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);

+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+       return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+       int ret;
+       bool bit;
+
+       ret = kstrtobool(buf, &bit);
+       if (ret)
+               return ret;
+
+       if (test_bit(FailFast, &rdev->flags) && !bit) {
+               clear_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       } else if (!test_bit(FailFast, &rdev->flags) && bit) {
+               set_bit(FailFast, &rdev->flags);
+               md_update_sb(rdev->mddev, 1);
+       }
+       return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
 static struct attribute *rdev_default_attrs[] = {
        &rdev_state.attr,
        &rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
        &rdev_unack_bad_blocks.attr,
        &rdev_ppl_sector.attr,
        &rdev_ppl_size.attr,
+       &rdev_fail_fast.attr,
        NULL,
 };
 static ssize_t
--
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help