[PATCH 5/5] tests: avoid passing chunk size to raid1.

Subsystems: the rest

STALE1834d

2 messages, 2 authors, 2021-08-02 · open the first message on its own page

[PATCH 5/5] tests: avoid passing chunk size to raid1.

From: Sudhakar Panneerselvam <hidden>
Date: 2021-07-22 18:29:46

'04update-metadata' test fails with error, "specifying chunk size is
forbidden for this level" added by commit, 5b30a34aa4b5e. Hence,
correcting the test to ignore passing chunk size to raid1.

Signed-off-by: Sudhakar Panneerselvam <redacted>
---
 tests/04update-metadata | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/04update-metadata b/tests/04update-metadata
index 08c14af7ed29..591009d2797e 100644
--- a/tests/04update-metadata
+++ b/tests/04update-metadata
@@ -11,7 +11,12 @@ dlist="$dev0 $dev1 $dev2 $dev3"
 for ls in linear/4 raid1/1 raid5/3 raid6/2
 do
   s=${ls#*/} l=${ls%/*}
-  mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
+  if [[ $l == 'raid1' ]]
+  then
+    mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 $dlist
+  else
+    mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
+  fi
   testdev $md0 $s 19904 64
   mdadm -S $md0
   mdadm -A $md0 --update=metadata $dlist
-- 
1.8.3.1

Re: [PATCH 5/5] tests: avoid passing chunk size to raid1.

From: Jes Sorensen <hidden>
Date: 2021-08-02 15:49:44

On 7/22/21 2:29 PM, Sudhakar Panneerselvam wrote:
quoted hunk
'04update-metadata' test fails with error, "specifying chunk size is
forbidden for this level" added by commit, 5b30a34aa4b5e. Hence,
correcting the test to ignore passing chunk size to raid1.

Signed-off-by: Sudhakar Panneerselvam <redacted>
---
 tests/04update-metadata | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/04update-metadata b/tests/04update-metadata
index 08c14af7ed29..591009d2797e 100644
--- a/tests/04update-metadata
+++ b/tests/04update-metadata
@@ -11,7 +11,12 @@ dlist="$dev0 $dev1 $dev2 $dev3"
 for ls in linear/4 raid1/1 raid5/3 raid6/2
 do
   s=${ls#*/} l=${ls%/*}
-  mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
+  if [[ $l == 'raid1' ]]
+  then
+    mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 $dlist
+  else
+    mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
+  fi
   testdev $md0 $s 19904 64
   mdadm -S $md0
   mdadm -A $md0 --update=metadata $dlist
I took a patch from Mateusz that fixed this in a more generic way. If
it's still a problem, please let me know.

Thanks,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help