[PATCH] Add error handling for chunk size in RAID1

Subsystems: the rest

STALE1853d

2 messages, 2 authors, 2021-07-16 · open the first message on its own page

[PATCH] Add error handling for chunk size in RAID1

From: Mateusz Grzonka <hidden>
Date: 2021-07-15 10:35:37

Print error if chunk size is set as it is not supported.

Signed-off-by: Mateusz Grzonka <redacted>
---
 Create.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Create.c b/Create.c
index 18b5e646..f5d57f8c 100644
--- a/Create.c
+++ b/Create.c
@@ -254,9 +254,8 @@ int Create(struct supertype *st, char *mddev,
 	case LEVEL_MULTIPATH:
 	case LEVEL_CONTAINER:
 		if (s->chunk) {
-			s->chunk = 0;
-			if (c->verbose > 0)
-				pr_err("chunk size ignored for this level\n");
+			pr_err("specifying chunk size is forbidden for this level\n");
+			return 1;
 		}
 		break;
 	default:
-- 
2.26.2

Re: [PATCH] Add error handling for chunk size in RAID1

From: Jes Sorensen <hidden>
Date: 2021-07-16 14:32:01

On 7/15/21 6:25 AM, Mateusz Grzonka wrote:
Print error if chunk size is set as it is not supported.

Signed-off-by: Mateusz Grzonka <redacted>
---
 Create.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Applied!

Thanks,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help