[PATCH 1/1] mdadm/super1: It needs to specify int32 for bitmap_offset

Subsystems: the rest

STALE1849d

3 messages, 2 authors, 2021-07-16 · open the first message on its own page

[PATCH 1/1] mdadm/super1: It needs to specify int32 for bitmap_offset

From: Xiao Ni <hidden>
Date: 2021-06-02 01:17:27 

For super1.0 bitmap offset is -16. So it needs to use int type for bitmap offset.

Fixes: 1fe2e1007310 (mdadm/bitmap: locate bitmap calcuate bitmap position wrongly)
Signed-off-by: Xiao Ni <redacted>
---
 super1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/super1.c b/super1.c
index c05e623..a12a5bc 100644
--- a/super1.c
+++ b/super1.c
@@ -2631,7 +2631,7 @@ static int locate_bitmap1(struct supertype *st, int fd, int node_num)
 	else
 		ret = -1;
 
-	offset = __le64_to_cpu(sb->super_offset) + __le32_to_cpu(sb->bitmap_offset);
+	offset = __le64_to_cpu(sb->super_offset) + (int32_t)__le32_to_cpu(sb->bitmap_offset);
 	if (node_num) {
 		bms = (bitmap_super_t*)(((char*)sb)+MAX_SB_SIZE);
 		bm_sectors_per_node = calc_bitmap_size(bms, 4096) >> 9;
-- 
2.7.5

Re: [PATCH 1/1] mdadm/super1: It needs to specify int32 for bitmap_offset

From: Xiao Ni <hidden>
Date: 2021-06-21 01:10:23 

Hi Jes

Ping, is the patch ok for you to merge it

Regards
Xiao

On Wed, Jun 2, 2021 at 9:17 AM Xiao Ni [off-list ref] wrote:
quoted hunk
For super1.0 bitmap offset is -16. So it needs to use int type for bitmap offset.

Fixes: 1fe2e1007310 (mdadm/bitmap: locate bitmap calcuate bitmap position wrongly)
Signed-off-by: Xiao Ni <redacted>
---
 super1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/super1.c b/super1.c
index c05e623..a12a5bc 100644
--- a/super1.c
+++ b/super1.c
@@ -2631,7 +2631,7 @@ static int locate_bitmap1(struct supertype *st, int fd, int node_num)
        else
                ret = -1;

-       offset = __le64_to_cpu(sb->super_offset) + __le32_to_cpu(sb->bitmap_offset);
+       offset = __le64_to_cpu(sb->super_offset) + (int32_t)__le32_to_cpu(sb->bitmap_offset);
        if (node_num) {
                bms = (bitmap_super_t*)(((char*)sb)+MAX_SB_SIZE);
                bm_sectors_per_node = calc_bitmap_size(bms, 4096) >> 9;
--
2.7.5





  

    
Re: [PATCH 1/1] mdadm/super1: It needs to specify int32 for bitmap_offset

    

      From: Jes Sorensen <hidden>

      Date: 2021-07-16 14:37:15 
    

  

  
On 6/1/21 9:17 PM, Xiao Ni wrote:
For super1.0 bitmap offset is -16. So it needs to use int type for bitmap offset.

Fixes: 1fe2e1007310 (mdadm/bitmap: locate bitmap calcuate bitmap position wrongly)
Signed-off-by: Xiao Ni <redacted>
---
 super1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!

Jes




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help