# Re: \[PATCH 12/26\] bcache: convert to blk\_alloc\_disk/blk\_cleanup\_disk

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-05-21 06:23:08 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2021/05/6402834
- Thread: https://ratatoskr.run/linux-block/2021/05/6402806/t.md

```text
On Fri, May 21, 2021 at 02:15:32PM +0800, Coly Li wrote:
> The  above 2 lines are added on purpose to prevent an refcount
> underflow. It is from commit 86da9f736740 ("bcache: fix refcount
> underflow in bcache_device_free()").
> 
> Maybe add a parameter to blk_cleanup_disk() or checking (disk->flags &
> GENHD_FL_UP) inside blk_cleanup_disk() ?

Please take a look at patch 4 in the series.
```